From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE069C6FD1D for ; Tue, 21 Mar 2023 08:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbjCUIqy convert rfc822-to-8bit (ORCPT ); Tue, 21 Mar 2023 04:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbjCUIqs (ORCPT ); Tue, 21 Mar 2023 04:46:48 -0400 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCC771B4; Tue, 21 Mar 2023 01:45:50 -0700 (PDT) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1peXcb-002Leu-VU; Tue, 21 Mar 2023 09:45:33 +0100 Received: from p57bd9952.dip0.t-ipconnect.de ([87.189.153.82] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1peXcb-001BoR-OK; Tue, 21 Mar 2023 09:45:33 +0100 Message-ID: Subject: Re: [PATCH 6/7 v5] sh: fix Kconfig entry for NUMA => SMP From: John Paul Adrian Glaubitz To: Geert Uytterhoeven Cc: Randy Dunlap , linux-kernel@vger.kernel.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, stable@vger.kernel.org Date: Tue, 21 Mar 2023 09:45:33 +0100 In-Reply-To: References: <20230320231310.28841-1-rdunlap@infradead.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.153.82 X-ZEDAT-Hint: PO Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org Hi Geert! On Tue, 2023-03-21 at 09:42 +0100, Geert Uytterhoeven wrote: > Hi Adrian, > > On Tue, Mar 21, 2023 at 9:10 AM John Paul Adrian Glaubitz > wrote: > > On Tue, 2023-03-21 at 08:55 +0100, Geert Uytterhoeven wrote: > > > On Tue, Mar 21, 2023 at 12:13 AM Randy Dunlap wrote: > > > > Fix SUPERH builds that select SYS_SUPPORTS_NUMA but do not select > > > > SYS_SUPPORTS_SMP and SMP. > > > > > > Perhaps because these SoCs do not support SMP? > > > > Well, there is actually a dual-core 7786 board available, see: > > > > > https://www.apnet.co.jp/product/superh/ap-sh4ad-0a.html > > > > Quoting: > > > > »The SH7786 is equipped with a dual-core SH-4A and has interfaces such as > > DDR3 SDRAM, PCI Express, USB, and display unit.« > > SH7786 is dual-core... > > > FWIW, I just realized we need this for config CPU_SUBTYPE_SH7786 as well. > > ... and CPU_SUBTYPE_SH7786 selects CPU_SHX3, which selects > SYS_SUPPORTS_SMP and SYS_SUPPORTS_NUMA in turn. > So everything is fine for SH7786. Yeah, this explains it then. Your new patch is definitely the better approach and I would prefer it over Randy's suggested change. Let's see what the mm maintainers have to say. Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913