From mboxrd@z Thu Jan 1 00:00:00 1970 From: acme@kernel.org (Arnaldo Carvalho de Melo) Date: Thu, 2 May 2019 11:41:34 -0400 Subject: perf tools build broken after v5.1-rc1 In-Reply-To: <20190502143618.GH21436@kernel.org> References: <20190422152027.GB11750@kernel.org> <20190501204115.GF21436@kernel.org> <20190502143618.GH21436@kernel.org> List-ID: Message-ID: <20190502154134.GA23984@kernel.org> To: linux-snps-arc@lists.infradead.org Em Thu, May 02, 2019 at 10:36:18AM -0400, Arnaldo Carvalho de Melo escreveu: > Em Wed, May 01, 2019 at 09:17:52PM +0000, Vineet Gupta escreveu: > > On 5/1/19 1:41 PM, Arnaldo Carvalho de Melo wrote: > > >> The 1a787fc5ba18ac7 commit copied over the changes for arm64, but > > >> missed all the other architectures changed in c8ce48f06503 and the > > >> related commits. > > > Right, I have a patch copying the missing headers, and that fixed the > > > build with the glibc-based toolchain, but then broke the uCLibc one :-\ > > > tools/perf/util/cloexec.c #includes which for glibc includes > > asm/unistd.h > > > uClibc OTOH #include containign#define __NR_* > > (generated by parsing kernel's unistd). This header does the right thing by > > chekcing for redefs, but in the end we still collide with newly added > > tools/arc/arc/*/**/unistd.h which doesn't have conditional definitions. I'm sure > > this is not an ARC problem, any uClibc build would be affected. Do you have a arm > > uclibc toolchain to test ? > > This solves it for fedora:29, > arc_gnu_2017.09-rc2_prebuilt_uclibc_le_arc700_linux_install, > arc_gnu_2019.03-rc1_prebuilt_uclibc_le_archs_linux_install and > arc_gnu_2019.03-rc1_prebuilt_glibc_le_archs_linux_install. > > Also ok with: > > make -C tools/perf build-test > > Now build testing with the full set of containers. So far, and the alpine ones use musl libc: [perfbuilder at quaco ~]$ export PERF_TARBALL=http://192.168.124.1/perf/perf-5.1.0-rc6.tar.xz [perfbuilder at quaco ~]$ time dm 1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0 2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822 3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0 4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0 5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0 6 alpine:3.9 : Ok gcc (Alpine 8.3.0) 8.3.0 7 alpine:edge : Ok gcc (Alpine 8.3.0) 8.3.0 8 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55) 12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) 13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36) 14 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u2) 4.9.2 15 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 16 debian:experimental : Ok gcc (Debian 8.3.0-6) 8.3.0 17 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.3.0-4) 8.3.0 18 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.3.0-4) 8.3.0 19 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 8.3.0-2) 8.3.0 20 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 8.3.0-4) 8.3.0 21 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7) 22 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6) 23 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6) 24 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1) 25 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710 - Arnaldo