Linux SNPS ARC Archive on
 help / color / Atom feed
From: Vineet Gupta <>
To:, Carlos O'Donell <>
Cc: Vineet Gupta <>,
Subject: [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list
Date: Sun, 19 Jul 2020 14:02:35 -0700
Message-ID: <> (raw)

These symbols were recently deprecated but the test still checks for
them which fails for ARC.

Tested with arc-linux-gnuhf

-FAIL: elf/tst-libc_dlvsym
+PASS: elf/tst-libc_dlvsym
-FAIL: elf/tst-libc_dlvsym-static
+PASS: elf/tst-libc_dlvsym-static

| $ cat elf/tst-libc_dlvsym-static.out
| error: tst-libc_dlvsym.h:103: symbol _sys_errlist not found at any version

  1. This does reduce test-coverage for existing ports with older
     versions of glibc where these symbols are valid, but reckon
     it is not an issue since the symbol is being deprecated anyways

  2. IMHO, despite the ABI freeze it should be fine for 2.32 too since
     it doesn't modify glibc ABI/API in any way, only a test-header is.
 elf/tst-libc_dlvsym.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h
index 6b132dd7c3e4..7eda47207824 100644
--- a/elf/tst-libc_dlvsym.h
+++ b/elf/tst-libc_dlvsym.h
@@ -117,8 +117,6 @@ compare_vsyms (void)
      obtain an explicit handle for  */
   void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD);
-  compare_vsyms_1 (libc_handle, "_sys_errlist");
-  compare_vsyms_1 (libc_handle, "_sys_siglist");
   compare_vsyms_1 (libc_handle, "quick_exit");
   xdlclose (libc_handle);

linux-snps-arc mailing list

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 21:02 Vineet Gupta [this message]
2020-07-20  7:26 ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux SNPS ARC Archive on

Archives are clonable:
	git clone --mirror linux-snps-arc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-snps-arc linux-snps-arc/ \
	public-inbox-index linux-snps-arc

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone