Linux SNPS ARC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list
@ 2020-07-19 21:02 Vineet Gupta
  2020-07-20  7:26 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: Vineet Gupta @ 2020-07-19 21:02 UTC (permalink / raw)
  To: libc-alpha, Carlos O'Donell; +Cc: Vineet Gupta, linux-snps-arc

These symbols were recently deprecated but the test still checks for
them which fails for ARC.

Tested with arc-linux-gnuhf

-FAIL: elf/tst-libc_dlvsym
+PASS: elf/tst-libc_dlvsym
-FAIL: elf/tst-libc_dlvsym-static
+PASS: elf/tst-libc_dlvsym-static

|
| $ cat elf/tst-libc_dlvsym-static.out
| error: tst-libc_dlvsym.h:103: symbol _sys_errlist not found at any version
|

caveats:
  1. This does reduce test-coverage for existing ports with older
     versions of glibc where these symbols are valid, but reckon
     it is not an issue since the symbol is being deprecated anyways

  2. IMHO, despite the ABI freeze it should be fine for 2.32 too since
     it doesn't modify glibc ABI/API in any way, only a test-header is.
---
 elf/tst-libc_dlvsym.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h
index 6b132dd7c3e4..7eda47207824 100644
--- a/elf/tst-libc_dlvsym.h
+++ b/elf/tst-libc_dlvsym.h
@@ -117,8 +117,6 @@ compare_vsyms (void)
      obtain an explicit handle for libc.so.  */
   void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD);
 
-  compare_vsyms_1 (libc_handle, "_sys_errlist");
-  compare_vsyms_1 (libc_handle, "_sys_siglist");
   compare_vsyms_1 (libc_handle, "quick_exit");
 
   xdlclose (libc_handle);
-- 
2.20.1


_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-19 21:02 [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list Vineet Gupta
2020-07-20  7:26 ` Florian Weimer

Linux SNPS ARC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-snps-arc/0 linux-snps-arc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-snps-arc linux-snps-arc/ https://lore.kernel.org/linux-snps-arc \
		linux-snps-arc@lists.infradead.org
	public-inbox-index linux-snps-arc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-snps-arc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git