From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: deller@gmx.de, geert@linux-m68k.org, javierm@redhat.com,
daniel@ffwll.ch, vgupta@kernel.org, chenhuacai@kernel.org,
kernel@xen0n.name, davem@davemloft.net,
James.Bottomley@hansenpartnership.com, arnd@arndb.de,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arch@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH 0/5] fbdev: Move framebuffer I/O helpers to <asm/fb.h>
Date: Wed, 26 Apr 2023 21:21:10 +0200 [thread overview]
Message-ID: <20230426192110.GA3791243@ravnborg.org> (raw)
In-Reply-To: <20230426130420.19942-1-tzimmermann@suse.de>
Hi Thomas.
On Wed, Apr 26, 2023 at 03:04:15PM +0200, Thomas Zimmermann wrote:
> Fbdev provides helpers for framebuffer I/O, such as fb_readl(),
> fb_writel() or fb_memcpy_to_fb(). The implementation of each helper
> depends on the architecture. It's still all located in fbdev's main
> header file <linux/fb.h>. Move all of it into each archtecture's
> <asm/fb.h>, with shared code in <asm-generic/fb.h>.
For once I think this cleanup is moving things in the wrong direction.
The fb_* helpers predates the generic io.h support and try to
add a generic layer for read read / write operations.
The right fix would be to migrate fb_* to use the io helpers
we have today - so we use the existing way to handle the architecture
specific details.
From a quick look there seems to be some challenges but the current
helpers that re-do part of io.h is not the way forward and hiding them
in arch/include/asm/fb.h seems counter productive.
Sam
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2023-04-26 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 13:04 [PATCH 0/5] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Thomas Zimmermann
2023-04-26 13:04 ` [PATCH 1/5] fbdev/matrox: Remove trailing whitespaces Thomas Zimmermann
2023-04-26 13:04 ` [PATCH 2/5] ipu-v3: Include <linux/io.h> Thomas Zimmermann
2023-04-26 13:04 ` [PATCH 3/5] fbdev: Include <linux/io.h> in various drivers Thomas Zimmermann
2023-04-26 13:04 ` [PATCH 4/5] fbdev: Include <linux/io.h> via <asm/fb.h> Thomas Zimmermann
2023-04-26 13:04 ` [PATCH 5/5] fbdev: Move framebuffer I/O helpers into <asm/fb.h> Thomas Zimmermann
2023-04-26 19:21 ` Sam Ravnborg [this message]
2023-04-27 7:22 ` [PATCH 0/5] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Thomas Zimmermann
2023-04-27 10:20 ` Arnd Bergmann
2023-04-27 17:17 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426192110.GA3791243@ravnborg.org \
--to=sam@ravnborg.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).