From: Min-Hua Chen <minhuadotchen@gmail.com>
To: Vineet Gupta <vgupta@kernel.org>
Cc: Min-Hua Chen <minhuadotchen@gmail.com>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ARC: rename 16KSTACKS to DEBUG_STACKS
Date: Fri, 12 May 2023 01:01:39 +0800 [thread overview]
Message-ID: <20230511170139.343434-3-minhuadotchen@gmail.com> (raw)
In-Reply-To: <20230511170139.343434-1-minhuadotchen@gmail.com>
Rename 16KSTACKS to DEBUG_STACKS.
arch/arc/Kconfig.debug says that the default stack size is 8KB
and it will become 16KB stack if 16KSTACKS is set.
However, the stack size is based on PAGE_SIZE, and it is
configurable by CONFIG_ARC_PAGE_SIZE_16K or CONFIG_ARC_PAGE_SIZE_4K.
See arch/arc/include/uapi/asm/page.h:
/* PAGE_SHIFT determines the page size */
\#if defined(CONFIG_ARC_PAGE_SIZE_16K)
\#define PAGE_SHIFT 14
\#elif defined(CONFIG_ARC_PAGE_SIZE_4K)
\#define PAGE_SHIFT 12
\#else
\#define PAGE_SHIFT 13
\#endif
See arch/arc/include/asm/thread_info.h:
\#ifdef CONFIG_DEBUG_STACKS
\#define THREAD_SIZE_ORDER 1
\#else
\#define THREAD_SIZE_ORDER 0
\#endif
\#define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)
\#define THREAD_SHIFT (PAGE_SHIFT + THREAD_SIZE_ORDER)
To make CONFIG_16KSTACKS less confusing, rename it to DEBUG_STACKS
(as it is defined in Kconfig.debug) and modify the Kconfig
description. No functional changes intended.
Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
arch/arc/Kconfig.debug | 7 ++++---
arch/arc/include/asm/thread_info.h | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/arc/Kconfig.debug b/arch/arc/Kconfig.debug
index 45add86decd5..9a1e140605c4 100644
--- a/arch/arc/Kconfig.debug
+++ b/arch/arc/Kconfig.debug
@@ -1,10 +1,11 @@
# SPDX-License-Identifier: GPL-2.0
-config 16KSTACKS
- bool "Use 16Kb for kernel stacks instead of 8Kb"
+config DEBUG_STACKS
+ bool "Use double sized kernel stacks"
help
- If you say Y here the kernel will use a 16Kb stacksize for the
+ If you say Y here the kernel will use a double sized stack for the
kernel stack attached to each process/thread. The default is 8K.
+ (depends on CONFIG_ARC_PAGE_SIZE_16K or CONFIG_ARC_PAGE_SIZE_4K)
This increases the resident kernel footprint and will cause less
threads to run on the system and also increase the pressure
on the VM subsystem for higher order allocations.
diff --git a/arch/arc/include/asm/thread_info.h b/arch/arc/include/asm/thread_info.h
index 9f9dd021501c..a7358d1225a6 100644
--- a/arch/arc/include/asm/thread_info.h
+++ b/arch/arc/include/asm/thread_info.h
@@ -15,7 +15,7 @@
#include <asm/page.h>
-#ifdef CONFIG_16KSTACKS
+#ifdef CONFIG_DEBUG_STACKS
#define THREAD_SIZE_ORDER 1
#else
#define THREAD_SIZE_ORDER 0
--
2.34.1
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2023-05-11 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 17:01 [PATCH 0/2] ARC: fix the THREAD_SHIFT definition Min-Hua Chen
2023-05-11 17:01 ` [PATCH 1/2] ARC: fix incorrect " Min-Hua Chen
2023-05-11 17:01 ` Min-Hua Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511170139.343434-3-minhuadotchen@gmail.com \
--to=minhuadotchen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).