From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
Vineet Gupta
<Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: Evgeniy Didin <Evgeniy.Didin@synopsys.com>,
arcml <linux-snps-arc@lists.infradead.org>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [PATCH v2] binutils/ARC: cleanup
Date: Thu, 10 Sep 2020 23:21:43 +0000 [thread overview]
Message-ID: <3b18564e-be2e-91b3-def1-6c3591288ecc@synopsys.com> (raw)
In-Reply-To: <20191222224144.38603994@windsurf>
Hi Thomas,
On 12/22/19 1:41 PM, Thomas Petazzoni wrote:
> Hello Vineet,
>
> On Tue, 17 Dec 2019 13:32:53 -0800
> Vineet Gupta <Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> wrote:
>
>> Remove special handling for ARC - as it is not needed for cksy etc.
>>
>> A nice side benefit is that the ARC specific version now only needs to
>> be specified in single place (vs 3 currently) in binutils/Config.in.host
>>
>> Signed-off-by: Vineet Gupta <vgupta-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
>> ---
>> package/binutils/binutils.mk | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
>> index a19d6940f7c1..3ae5561d67d3 100644
>> --- a/package/binutils/binutils.mk
>> +++ b/package/binutils/binutils.mk
>> @@ -8,14 +8,10 @@
>> # If not, we do like other packages
>> BINUTILS_VERSION = $(call qstrip,$(BR2_BINUTILS_VERSION))
>> ifeq ($(BINUTILS_VERSION),)
>> -ifeq ($(BR2_arc),y)
>> -BINUTILS_VERSION = arc-2019.09-rc1
>> -else
>> BINUTILS_VERSION = 2.32
>> endif
>> -endif # BINUTILS_VERSION
>>
>> -ifeq ($(BINUTILS_VERSION),arc-2019.09-rc1)
>> +ifeq ($(BR2_BINUTILS_VERSION_ARC),y)
Looks like we need this specific thunk anyways. When I select pristine upstream
binutils (not ARC fork @ github), the above forces it to download from github
which it should not and will not if the tag/branch has not been mirrored there.
>> BINUTILS_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,binutils-gdb,$(BINUTILS_VERSION))
>> BINUTILS_SOURCE = binutils-gdb-$(BINUTILS_VERSION).tar.gz
>> BINUTILS_FROM_GIT = y
>
> In fact, I was wrong, this also does not work, in the following
> situation:
>
> - You're using a pre-compiled external toolchain, so host-binutils is
> not selected/enabled, so the version selection in
> package/binutils/Config.in.host is not used, and therefore
> BR2_BINUTILS_VERSION_ARC cannot be set to 'y'.
>
> - You have binutils enabled for the target.
>
> Then, with your patch, we will no longer select the ARC-specific fork
> of binutils.
>
> Basically, for the target binutils (just like for target gdb), we don't
> have any version selection, so we force using one specific version
> depending on the architecture.
>
> Best regards,
>
> Thomas
>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-09-10 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 19:39 [PATCH 0/3] ARC toolchian related fixes Vineet Gupta
2019-12-06 19:39 ` [PATCH 1/3] toolchain,glibc: Allow ARC big endian glibc builds Vineet Gupta
2019-12-06 21:18 ` [Buildroot] [PATCH 1/3] toolchain, glibc: " Thomas Petazzoni
2019-12-06 19:39 ` [PATCH 2/3] binutils/ARC: move ARC specific code together Vineet Gupta
2019-12-06 21:19 ` [Buildroot] " Thomas Petazzoni
2019-12-17 21:32 ` [PATCH v2] binutils/ARC: cleanup Vineet Gupta
2019-12-22 21:41 ` [Buildroot] " Thomas Petazzoni
2020-01-13 17:48 ` Vineet Gupta
2020-09-10 23:21 ` Vineet Gupta [this message]
2020-09-11 9:18 ` Thomas Petazzoni
2020-09-11 19:37 ` Vineet Gupta
2019-12-06 19:39 ` [PATCH 3/3] toolchain/ARC: Enable ability to build with upstream gcc/binutils Vineet Gupta
2019-12-06 21:26 ` [Buildroot] " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b18564e-be2e-91b3-def1-6c3591288ecc@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Evgeniy.Didin@synopsys.com \
--cc=Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=buildroot@buildroot.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).