From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Evgeniy Didin <Evgeniy.Didin@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Subject: Re: [PATCH] ARC: [plat-hsdk]: Switch ethernet phy-mode to rgmii-id
Date: Tue, 1 Sep 2020 18:41:50 +0000 [thread overview]
Message-ID: <5ec34714-3a9b-be13-a702-d2cd5e6c2eba@synopsys.com> (raw)
In-Reply-To: <20200707153858.13280-1-Evgeniy.Didin@synopsys.com>
On 7/7/20 8:38 AM, Evgeniy Didin wrote:
> HSDK board has Micrel KSZ9031, recent commit
> bcf3440c6dd ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> caused a breakdown of Ethernet.
> Using 'phy-mode = "rgmii"' is not correct because accodring RGMII
> specification it is necessary to have delay on RX (PHY to MAX)
> which is not generated in case of "rgmii".
> Using "rgmii-id" adds necessary delay and solves the issue.
>
> Also adding name of PHY placed on HSDK board.
>
> Signed-off-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com>
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
@Alexey - u ok with this change ?
-Vineet
> ---
> arch/arc/boot/dts/hsdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index 9acbeba832c0..d6427d47e5a1 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -208,7 +208,7 @@
> reg = <0x8000 0x2000>;
> interrupts = <10>;
> interrupt-names = "macirq";
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> snps,pbl = <32>;
> snps,multicast-filter-bins = <256>;
> clocks = <&gmacclk>;
> @@ -226,7 +226,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "snps,dwmac-mdio";
> - phy0: ethernet-phy@0 {
> + phy0: ethernet-phy@0 { /* Micrel KSZ9031 */
> reg = <0>;
> };
> };
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-09-01 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 15:38 [PATCH] ARC: [plat-hsdk]: Switch ethernet phy-mode to rgmii-id Evgeniy Didin
2020-09-01 18:41 ` Vineet Gupta [this message]
2020-09-01 18:46 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec34714-3a9b-be13-a702-d2cd5e6c2eba@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Evgeniy.Didin@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).