From: Florian Weimer <fweimer@redhat.com>
To: Vineet Gupta via Libc-alpha <libc-alpha@sourceware.org>
Cc: Carlos O'Donell <carlos@redhat.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list
Date: Mon, 20 Jul 2020 09:26:30 +0200 [thread overview]
Message-ID: <87v9iizly1.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200719210235.21767-1-vgupta@synopsys.com> (Vineet Gupta via Libc-alpha's message of "Sun, 19 Jul 2020 14:02:35 -0700")
* Vineet Gupta via Libc-alpha:
> diff --git a/elf/tst-libc_dlvsym.h b/elf/tst-libc_dlvsym.h
> index 6b132dd7c3e4..7eda47207824 100644
> --- a/elf/tst-libc_dlvsym.h
> +++ b/elf/tst-libc_dlvsym.h
> @@ -117,8 +117,6 @@ compare_vsyms (void)
> obtain an explicit handle for libc.so. */
> void *libc_handle = xdlopen (LIBC_SO, RTLD_LAZY | RTLD_NOLOAD);
>
> - compare_vsyms_1 (libc_handle, "_sys_errlist");
> - compare_vsyms_1 (libc_handle, "_sys_siglist");
> compare_vsyms_1 (libc_handle, "quick_exit");
>
> xdlclose (libc_handle);
Please use TEST_COMPAT, as in malloc/tst-mallocstate.c.
Thanks,
Florian
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2020-07-20 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 21:02 [PATCH] Fix tst-libc_dlvsym{, -static} on ARC: don't check _sys_{err, sig}list Vineet Gupta
2020-07-20 7:26 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9iizly1.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).