From: Thomas Zimmermann <tzimmermann@suse.de>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de,
javierm@redhat.com, gregkh@linuxfoundation.org
Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org,
Rich Felker <dalias@libc.org>,
linux-ia64@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, loongarch@lists.linux.dev,
sparclinux@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 16/19] arch/sh: Implement <asm/fb.h> with generic helpers
Date: Mon, 17 Apr 2023 16:07:10 +0200 [thread overview]
Message-ID: <8e47f91e-709b-453f-55e5-a7abd2dfe1dd@suse.de> (raw)
In-Reply-To: <132f1185-d61f-b8c7-8d6e-4e4280a1a4ad@suse.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 2244 bytes --]
Am 17.04.23 um 16:06 schrieb Thomas Zimmermann:
> Hi
>
> Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz:
>> Hi Thomas!
>>
>> On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote:
>>> Replace the architecture's fbdev helpers with the generic
>>> ones from <asm-generic/fb.h>. No functional changes.
>>>
>>> v2:
>>> * use default implementation for fb_pgprotect() (Arnd)
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>>> Cc: Rich Felker <dalias@libc.org>
>>> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>>> ---
>>> arch/sh/include/asm/fb.h | 15 +--------------
>>> 1 file changed, 1 insertion(+), 14 deletions(-)
>>>
>>> diff --git a/arch/sh/include/asm/fb.h b/arch/sh/include/asm/fb.h
>>> index 9a0bca2686fd..19df13ee9ca7 100644
>>> --- a/arch/sh/include/asm/fb.h
>>> +++ b/arch/sh/include/asm/fb.h
>>> @@ -2,19 +2,6 @@
>>> #ifndef _ASM_FB_H_
>>> #define _ASM_FB_H_
>>> -#include <linux/fb.h>
>>> -#include <linux/fs.h>
>>> -#include <asm/page.h>
>>> -
>>> -static inline void fb_pgprotect(struct file *file, struct
>>> vm_area_struct *vma,
>>> - unsigned long off)
>>> -{
>>> - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
>>> -}
>>
>> Looking at the macro in asm-generic/fb.h, fb_pgprotect() is being
>> replaced with
>> a no-op function. Is that intentional? Can you briefly explain the
>> background
>> for this change?
>
> Patch 01 of this patchset changes the generic fb_pgprotect() to set
> pgprot_writecombine(). So on SH, there should be no change at all.
In case you didn't receive that patch:
https://patchwork.freedesktop.org/patch/532493/?series=116157&rev=3
>
> Best regards
> Thomas
>
>>
>>> -static inline int fb_is_primary_device(struct fb_info *info)
>>> -{
>>> - return 0;
>>> -}
>>> +#include <asm-generic/fb.h>
>>> #endif /* _ASM_FB_H_ */
>>
>> Thanks,
>> Adrian
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2023-04-17 14:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 12:56 [PATCH v3 00/19] arch: Consolidate <asm/fb.h> Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 01/19] fbdev: Prepare generic architecture helpers Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 02/19] arch/arc: Implement <asm/fb.h> with generic helpers Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 03/19] arch/arm: " Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 04/19] arch/arm64: " Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 05/19] arch/ia64: " Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 06/19] arch/loongarch: " Thomas Zimmermann
2023-06-28 10:26 ` WANG Xuerui
2023-04-17 12:56 ` [PATCH v3 07/19] arch/m68k: Merge variants of fb_pgprotect() into single function Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 08/19] arch/m68k: Implement <asm/fb.h> with generic helpers Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 09/19] arch/mips: " Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 10/19] video: Remove trailing whitespaces Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 11/19] video: Move HP PARISC STI core code to shared location Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 12/19] arch/parisc: Remove trailing whitespaces Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 13/19] arch/parisc: Implement fb_is_primary_device() under arch/parisc Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 14/19] arch/parisc: Implement <asm/fb.h> with generic helpers Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 15/19] arch/powerpc: " Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 16/19] arch/sh: " Thomas Zimmermann
2023-04-17 13:02 ` John Paul Adrian Glaubitz
2023-04-17 14:06 ` Thomas Zimmermann
2023-04-17 14:07 ` Thomas Zimmermann [this message]
2023-04-17 14:13 ` John Paul Adrian Glaubitz
2023-04-17 14:16 ` Thomas Zimmermann
2023-04-17 14:21 ` John Paul Adrian Glaubitz
2023-04-17 12:56 ` [PATCH v3 17/19] arch/sparc: Implement fb_is_primary_device() in source file Thomas Zimmermann
2023-06-24 1:55 ` [v3,17/19] " Guenter Roeck
2023-06-24 9:27 ` Arnd Bergmann
2023-06-24 13:26 ` Guenter Roeck
2023-06-24 14:21 ` Arnd Bergmann
2023-06-28 10:01 ` Arnd Bergmann
2023-04-17 12:56 ` [PATCH v3 18/19] arch/sparc: Implement <asm/fb.h> with generic helpers Thomas Zimmermann
2023-04-17 12:56 ` [PATCH v3 19/19] arch/x86: " Thomas Zimmermann
2023-04-17 14:12 ` [PATCH v3 00/19] arch: Consolidate <asm/fb.h> Arnd Bergmann
2023-04-18 7:44 ` Thomas Zimmermann
2023-04-19 17:22 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e47f91e-709b-453f-55e5-a7abd2dfe1dd@suse.de \
--to=tzimmermann@suse.de \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=daniel.vetter@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).