From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFEB5C35250 for ; Mon, 10 Feb 2020 05:36:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3042214DB for ; Mon, 10 Feb 2020 05:36:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WrFrw3/r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3042214DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=In3ZLnxdVI7PEBqE6dRf0r3Db37tb4DxD0+7u6BBZDY=; b=WrFrw3/r+OnJic cV3kyHQcpdingHeJii16Ui1hri/ibJ/WeeLOspAn8cINhdy4RgDEA9WZib2cIFEkDUPI9XJEu5wA9 89K2sH4cYo+Y8AmGk+mbT89AFvg7rIl3JZiQWavQh+PVvC9E3dQ9RsJIoau9EnpKgITuxfj/cFDd9 wKJpkyMb6but0KwhC6TtWcGw4ScAwgVlm4Si62OgoqIsSU+kHjgYSmUTU3wa8LypdDIuoM6JTfQ9a uE2XAwJ0i78fde6doDSHvlUQEePCfXhuW5owFG/RsICOXD2sx/vH3Pa5sypkaopOZ3mPxl6EehvoS dAifi4qJC/kgApBOuOaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j11jl-0006gu-PK; Mon, 10 Feb 2020 05:36:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j11jh-0006fB-SB; Mon, 10 Feb 2020 05:35:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0FFED31B; Sun, 9 Feb 2020 21:35:54 -0800 (PST) Received: from [10.163.1.162] (unknown [10.163.1.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37C1D3F68F; Sun, 9 Feb 2020 21:35:34 -0800 (PST) Subject: Re: [PATCH V13] mm/debug: Add tests validating architecture page table helpers To: Andrew Morton References: <1580897674-16456-1-git-send-email-anshuman.khandual@arm.com> <202002060619.wEOdAZU1%lkp@intel.com> <78d3ce6b-e100-2561-6b09-124c29731d1a@arm.com> <20200209205231.44d098f8749e88190b8ba10c@linux-foundation.org> From: Anshuman Khandual Message-ID: <955229f7-f161-f720-0e75-a3163f63817d@arm.com> Date: Mon, 10 Feb 2020 11:05:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200209205231.44d098f8749e88190b8ba10c@linux-foundation.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200209_213558_000282_453CEC48 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , uclinux-h8-devel@lists.sourceforge.jp, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Dan Williams , linux-s390@vger.kernel.org, kbuild test robot , Yoshinori Sato , Max Filippov , Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Geert Uytterhoeven , Gerald Schaefer , Mark Salter , Matt Turner , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Ingo Molnar , linux-xtensa@linux-xtensa.org, Kees Cook , Masahiro Yamada , linux-alpha@vger.kernel.org, Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Mark Brown , Ivan Kokshaysky , Paul Walmsley , "Kirill A . Shutemov" , Thomas Gleixner , Guan Xuetao , Vlastimil Babka , Richard Henderson , Christophe Leroy , Chris Zankel , Michal Simek , kbuild-all@lists.01.org, Brian Cain , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Palmer Dabbelt , Vineet Gupta , Martin Schwidefsky , Qian Cai , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 02/10/2020 10:22 AM, Andrew Morton wrote: > On Thu, 6 Feb 2020 13:49:35 +0530 Anshuman Khandual wrote: > >> >> On 02/06/2020 04:40 AM, kbuild test robot wrote: >>> Hi Anshuman, >>> >>> Thank you for the patch! Yet something to improve: >>> >>> [auto build test ERROR on powerpc/next] >>> [also build test ERROR on s390/features linus/master arc/for-next v5.5] >>> [cannot apply to mmotm/master tip/x86/core arm64/for-next/core next-20200205] >>> [if your patch is applied to the wrong git tree, please drop us a note to help >>> improve the system. BTW, we also suggest to use '--base' option to specify the >>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982] >>> >>> url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-debug-Add-tests-validating-architecture-page-table-helpers/20200205-215507 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next >>> config: ia64-allmodconfig (attached as .config) >>> compiler: ia64-linux-gcc (GCC) 7.5.0 >>> reproduce: >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # save the attached .config to linux build tree >>> GCC_VERSION=7.5.0 make.cross ARCH=ia64 >>> >>> If you fix the issue, kindly add following tag >>> Reported-by: kbuild test robot >>> >>> All error/warnings (new ones prefixed by >>): >>> >>> In file included from include/asm-generic/pgtable-nopud.h:8:0, >>> from arch/ia64/include/asm/pgtable.h:586, >>> from include/linux/mm.h:99, >>> from include/linux/highmem.h:8, >>> from mm/debug_vm_pgtable.c:14: >>> mm/debug_vm_pgtable.c: In function 'pud_clear_tests': >>>>> include/asm-generic/pgtable-nop4d-hack.h:47:32: error: implicit declaration of function '__pgd'; did you mean '__p4d'? [-Werror=implicit-function-declaration] >>> #define __pud(x) ((pud_t) { __pgd(x) }) >>> ^ >>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>> pud = __pud(pud_val(pud) | RANDOM_ORVALUE); >>> ^~~~~ >>>>> include/asm-generic/pgtable-nop4d-hack.h:47:22: warning: missing braces around initializer [-Wmissing-braces] >>> #define __pud(x) ((pud_t) { __pgd(x) }) >>> ^ >>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>> pud = __pud(pud_val(pud) | RANDOM_ORVALUE); >>> ^~~~~ >>> cc1: some warnings being treated as errors >> >> This build failure is expected now given that we have allowed DEBUG_VM_PGTABLE >> with EXPERT without platform requiring ARCH_HAS_DEBUG_VM_PGTABLE. This problem >> i.e build failure caused without a platform __pgd(), is known to exist both on >> ia64 and arm (32bit) platforms. Please refer https://lkml.org/lkml/2019/9/24/314 >> for details where this was discussed earlier. >> > > I'd prefer not to merge a patch which is known to cause build > regressions. Is there some temporary thing we can do to prevent these > errors until arch maintainers(?) get around to implementing the > long-term fixes? We could explicitly disable CONFIG_DEBUG_VM_PGTABLE on ia64 and arm platforms which will ensure that others can still use the EXPERT path. config DEBUG_VM_PGTABLE bool "Debug arch page table for semantics compliance" depends on MMU depends on !(IA64 || ARM) depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT default n if !ARCH_HAS_DEBUG_VM_PGTABLE default y if DEBUG_VM _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc