From: christophe.leroy@c-s.fr (Christophe Leroy)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture page table helpers
Date: Fri, 13 Sep 2019 12:01:00 +0200 [thread overview]
Message-ID: <95ed9d92-dd43-4c45-2e52-738aed7f2fb5@c-s.fr> (raw)
In-Reply-To: <502c497a-9bf1-7d2e-95f2-cfebcd9cf1d9@arm.com>
Le 13/09/2019 ? 11:02, Anshuman Khandual a ?crit?:
>
>>> +#if !defined(__PAGETABLE_PMD_FOLDED) && !defined(__ARCH_HAS_4LEVEL_HACK)
>>
>> #ifdefs have to be avoided as much as possible, see below
>
> Yeah but it has been bit difficult to avoid all these $ifdef because of the
> availability (or lack of it) for all these pgtable helpers in various config
> combinations on all platforms.
As far as I can see these pgtable helpers should exist everywhere at
least via asm-generic/ files.
Can you spot a particular config which fails ?
>
>>
[...]
>>> +#if !defined(__PAGETABLE_PUD_FOLDED) && !defined(__ARCH_HAS_5LEVEL_HACK)
>>
>> The same can be done here.
>
> IIRC not only the page table helpers but there are data types (pxx_t) which
> were not present on various configs and these wrappers help prevent build
> failures. Any ways will try and see if this can be improved further. But
> meanwhile if you have some suggestions, please do let me know.
pgt_t and pmd_t are everywhere I guess.
then pud_t and p4d_t have fallbacks in asm-generic files.
So it shouldn't be an issue. Maybe if a couple of arches miss them, the
best would be to fix the arches, since that's the purpose of your
testsuite isn't it ?
Christophe
next prev parent reply other threads:[~2019-09-13 10:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 6:02 [PATCH V2 0/2] mm/debug: Add tests for architecture exported page table helpers Anshuman Khandual
2019-09-12 6:02 ` [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture " Anshuman Khandual
2019-09-12 11:00 ` Kirill A. Shutemov
2019-09-12 12:09 ` Anshuman Khandual
2019-09-12 15:00 ` Christophe Leroy
2019-09-12 15:36 ` Christophe Leroy
2019-09-12 15:52 ` Christophe Leroy
2019-09-13 6:30 ` Christophe Leroy
2019-09-12 17:14 ` Christophe Leroy
2019-09-13 6:23 ` [PATCH] mm/pgtable/debug: Fix " Christophe Leroy
2019-09-13 6:58 ` Anshuman Khandual
2019-09-13 7:03 ` Christophe Leroy
2019-09-13 7:11 ` Christophe Leroy
2019-09-13 8:42 ` Anshuman Khandual
2019-09-13 8:51 ` Kirill A. Shutemov
2019-09-18 7:32 ` Anshuman Khandual
2019-09-19 5:44 ` Christophe Leroy
2019-09-13 9:02 ` [PATCH V2 2/2] mm/pgtable/debug: Add " Anshuman Khandual
2019-09-13 9:13 ` Kirill A. Shutemov
2019-09-13 10:01 ` Christophe Leroy [this message]
2019-09-18 5:04 ` Anshuman Khandual
2019-09-18 16:26 ` Christophe Leroy
2019-09-18 18:22 ` Gerald Schaefer
2019-09-20 4:06 ` Anshuman Khandual
2019-09-19 4:56 ` Anshuman Khandual
2019-09-19 5:41 ` Christophe Leroy
2019-09-12 14:42 ` [PATCH V2 0/2] mm/debug: Add tests for architecture exported " Christophe Leroy
2019-09-13 6:24 ` Anshuman Khandual
2019-09-13 6:32 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95ed9d92-dd43-4c45-2e52-738aed7f2fb5@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).