Linux SNPS ARC Archive on lore.kernel.org
 help / color / Atom feed
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: arcml <linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH v7.1 01/13] ARC: ABI Implementation
Date: Wed, 1 Jul 2020 19:36:13 +0000
Message-ID: <96a79297-9161-89a2-25d6-473979525367@synopsys.com> (raw)
In-Reply-To: <b6322150-240a-5f06-b700-83e3eb79deec@linaro.org>

On 7/1/20 9:50 AM, Adhemerval Zanella via Libc-alpha wrote:
> 
> 
> On 30/06/2020 21:06, Vineet Gupta via Libc-alpha wrote:
>> This code deals with the ARC ABI.
>> ---
>>    Changes since v7:
>>      - Used void * (iso int *) in tls-macros.h
> 
> LGTM, with just a couple of syntax nits below.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Thx. I suppose the process for new ports is to have a Reviewed-by on all patches,
squash them and push in 1 go (although in past I was asked to push the ARC elf
header patch).
Also do we need more than 1 Reviewed-by for this to be "push worthy" ?

>> +ENTRY (__longjmp)
>> +
>> +	LDR (blink, r0,  0)
>> +	LDR (sp,    r0,  1)
>> +	LDR (fp,    r0,  2)
>> +	LDR (gp,    r0,  3)
>> +
>> +	LDR (r13,   r0,  4)
>> +	LDR (r14,   r0,  5)
>> +	LDR (r15,   r0,  6)
>> +	LDR (r16,   r0,  7)
>> +	LDR (r17,   r0,  8)
>> +	LDR (r18,   r0,  9)
>> +	LDR (r19,   r0, 10)
>> +	LDR (r20,   r0, 11)
>> +	LDR (r21,   r0, 12)
>> +	LDR (r22,   r0, 13)
>> +	LDR (r23,   r0, 14)
>> +	LDR (r24,   r0, 15)
>> +
>> +	mov.f  r0, r1
>> +	j.d    [blink]
>> +	mov.z  r0, 1	/* don't return 0 to setjmp callsite from longjmp.  */
>> +
>> +END (__longjmp)
> 
> Ok, you have removed r25 save as pre previous discussion.

Right, and GP is being saved now.

>> diff --git a/sysdeps/arc/bits/setjmp.h b/sysdeps/arc/bits/setjmp.h
>> new file mode 100644
>> index 000000000000..6bba95fafe0f
>> --- /dev/null
>> +++ b/sysdeps/arc/bits/setjmp.h
>> @@ -0,0 +1,26 @@
>> +/* Define the machine-dependent type `jmp_buf'.  ARC version.
> 
> I think current trend is to just use apostrophe instead of the grave
> accent in such cases.

Ok changed.

>> +reloc_index (uintptr_t plt0, uintptr_t pltn, size_t size)
>> +{
>> +  unsigned long int idx = pltn - plt0;
>> +
>> +  /* PLT trampoline is 16 bytes. */
> 
> Double space after period.

Fixed.

>> +#define _JMPBUF_UNWINDS_ADJ(_jmpbuf, _address, _adj) \
>> +  ((uintptr_t) (_address) - (_adj) < (uintptr_t) (_jmpbuf_sp (_jmpbuf) - (_adj)))
>> +
>> +/* We use the normal longjmp for unwinding.  */
>> +#define __libc_unwind_longjmp(buf, val) __libc_longjmp (buf, val)
> 
> Ok. As a side note teh jmpbuf-unwind.h is candidate for some consolidation
> (the same macros are replicated in each architecture).

OK.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

  parent reply index

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 20:14 [PATCH v7 00/13] glibc port to ARC processors Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 01/13] ARC: ABI Implementation Vineet Gupta
2020-07-01  0:06   ` [PATCH v7.1 " Vineet Gupta
     [not found]     ` <b6322150-240a-5f06-b700-83e3eb79deec@linaro.org>
2020-07-01 19:36       ` Vineet Gupta [this message]
2020-07-01 19:45         ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 02/13] ARC: startup and dynamic linking code Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 03/13] ARC: Thread Local Storage support Vineet Gupta
2020-07-01  0:07   ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 04/13] ARC: Atomics and Locking primitives Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 05/13] ARC: math soft float support Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 06/13] ARC: hardware floating point support Vineet Gupta
2020-07-01  0:08   ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 07/13] ARC: Linux Syscall Interface Vineet Gupta
2020-07-01  0:08   ` [PATCH v7.1 " Vineet Gupta
     [not found]     ` <e9e2ae28-cd78-5924-c1fa-52b1499c245a@linaro.org>
2020-07-04  3:54       ` Vineet Gupta
2020-07-06 13:20         ` Adhemerval Zanella
2020-07-07  1:25           ` Vineet Gupta
2020-07-07 19:24             ` Adhemerval Zanella
2020-07-07 20:55               ` [PATCH v7.2 " Vineet Gupta
     [not found]                 ` <b64d0df1-4229-d619-0ab1-ded287323775@linaro.org>
2020-07-08 19:32                   ` Vineet Gupta
2020-07-09 16:03                     ` Adhemerval Zanella
2020-07-09 16:24                       ` Vineet Gupta
2020-07-09 16:25                         ` Adhemerval Zanella
2020-07-09 21:13                         ` Vineet Gupta
2020-07-09 21:36                           ` ARC testsuite regressions (was Re: [PATCH v7.2 07/13] ARC: Linux Syscall Interface) Vineet Gupta
2020-07-09 22:01                             ` Alistair Francis
2020-07-09 22:16                               ` Vineet Gupta
2020-07-10  9:28                               ` Florian Weimer
2020-07-10 15:53                                 ` Vineet Gupta
2020-07-10 17:02                                   ` Florian Weimer
2020-07-10 20:07                                     ` Vineet Gupta
2020-07-10 20:32                                       ` Florian Weimer
2020-07-10 19:12                                   ` Alistair Francis
2020-07-10 20:33                                     ` Florian Weimer
2020-07-10 20:56                                       ` Alistair Francis
2020-07-10 19:10                                 ` Alistair Francis
2020-07-07 21:07               ` [PATCH v7.1 07/13] ARC: Linux Syscall Interface Vineet Gupta
2020-07-07 21:32                 ` Joseph Myers
2020-07-07 23:16                   ` Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 08/13] ARC: Linux ABI Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 09/13] ARC: Linux Startup and Dynamic Loading Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 10/13] ARC: ABI lists Vineet Gupta
2020-07-01  0:09   ` [PATCH v7.1 " Vineet Gupta
2020-06-15 20:14 ` [PATCH v7 11/13] ARC: Build Infrastructure Vineet Gupta
2020-07-03 17:09   ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 12/13] build-many-glibcs.py: Enable ARC builds Vineet Gupta
2020-07-03 17:37   ` Adhemerval Zanella
2020-06-15 20:14 ` [PATCH v7 13/13] Documentation for ARC port Vineet Gupta
2020-07-03 17:38   ` Adhemerval Zanella
2020-06-23 16:56 ` [PATCH v7 00/13] glibc port to ARC processors Vineet Gupta
2020-07-01  0:11   ` Vineet Gupta
2020-07-01  1:44     ` Adhemerval Zanella
2020-07-01 19:13       ` Vineet Gupta
2020-07-02  1:00         ` ARC math test regressions (was Re: [PATCH v7 00/13] glibc port to ARC processors) Vineet Gupta
2020-07-02  7:17           ` Andreas Schwab
2020-07-02 16:27           ` Joseph Myers
2020-07-02 17:45             ` Vineet Gupta
2020-07-02 21:27       ` [PATCH v7 00/13] glibc port to ARC processors Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96a79297-9161-89a2-25d6-473979525367@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux SNPS ARC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-snps-arc/0 linux-snps-arc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-snps-arc linux-snps-arc/ https://lore.kernel.org/linux-snps-arc \
		linux-snps-arc@lists.infradead.org
	public-inbox-index linux-snps-arc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-snps-arc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git