From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] dl-runtime: reloc_{offset,index} now functions arch overide'able
Date: Fri, 29 May 2020 17:54:00 -0300 [thread overview]
Message-ID: <9ec385e5-3427-f3ac-f4c8-73f0c98aaa97@linaro.org> (raw)
In-Reply-To: <0f9ad824-2278-a55b-7203-96497f06c198@synopsys.com>
On 29/05/2020 14:39, Vineet Gupta wrote:
> On 5/29/20 5:58 AM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 28/05/2020 16:43, Vineet Gupta wrote:
>>> The existing macros are fragile and expect local variables with a
>>> certain name. Fix this by defining them as functions with defaul
>>> timplementation in a new header dl-runtime.h which arches can overrid
>>> eif need be.
>>>
>>> This came up during ARC port review.
>>>
>>> This patch potentially only affects hppa/x86 ports,
>>> build tested for both those configs and a few more.
>>>
>>> Suggested-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> Sorry I didn't think through this before, but ARC port needs pltgot arg (runtime
> address of plt0) in reloc_index not reloc_offset. I'll swap them and repost.
Hum I though I had it covered on my suggestion, but it seems I mixed them
up. Ok, I will review the new version.
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2020-05-29 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 19:43 [PATCH] dl-runtime: reloc_{offset, index} now functions arch overide'able Vineet Gupta
2020-05-29 12:58 ` [PATCH] dl-runtime: reloc_{offset,index} " Adhemerval Zanella
2020-05-29 17:39 ` Vineet Gupta
2020-05-29 20:54 ` Adhemerval Zanella [this message]
2020-05-29 21:21 ` [PATCH 1/2] dl-runtime: reloc_{offset, index} " Vineet Gupta
2020-05-29 21:21 ` [PATCH 2/2] ARC/dl-runtime helper macros Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec385e5-3427-f3ac-f4c8-73f0c98aaa97@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).