From: Joseph Myers <joseph@codesourcery.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org, libc-alpha@sourceware.org
Subject: Re: [PATCH] ieee754/dbl-64: Reduce the scope of temporary storage variables
Date: Mon, 11 Nov 2019 22:33:46 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1911112228550.30786@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20191111194349.21813-1-vgupta@synopsys.com>
On Mon, 11 Nov 2019, Vineet Gupta wrote:
> Functionally it should not result in code gen changes and if at all
> those would be better since the scope of those temporaries is greatly
> reduced now
This feels like the sort of thing where "should not result in code gen
changes" should be tested by running build-many-glibcs.py --strip with
unmodified glibc sources to build a full set of stripped glibc binaries,
saving those binaries and then running build-many-glibcs.py --strip again
and comparing the two sets of shared libraries (something I did a lot of
when reworking how libm function aliases were defined; static libraries
are expected to change because of timestamps, but shared library binaries
can be usefully compared like this). If the two sets of stripped binaries
are indeed identical, that is strong evidence that the patch is safe;
otherwise, review of the patch will require more detailed inspection of
the types of the arguments to these macros, and the uses of the temporary
variables, at every call site, to make sure that semantics aren't being
changed.
(In any case, please specify when submitting a patch how it was tested.)
--
Joseph S. Myers
joseph@codesourcery.com
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2019-11-11 22:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 19:43 [PATCH] ieee754/dbl-64: Reduce the scope of temporary storage variables Vineet Gupta
2019-11-11 22:33 ` Joseph Myers [this message]
2019-11-11 22:43 ` Vineet Gupta
2019-11-11 22:52 ` Joseph Myers
2020-06-02 2:32 ` [PATCH v2] " Vineet Gupta
2020-06-02 18:16 ` Joseph Myers
2020-06-02 20:31 ` Vineet Gupta
2020-06-04 19:08 ` Vineet Gupta
2020-06-15 19:09 ` Vineet Gupta
2020-06-15 19:43 ` Adhemerval Zanella
2020-06-15 19:53 ` Joseph Myers
2020-06-15 20:12 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911112228550.30786@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).