Linux SNPS ARC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] Enabling MSI for Microblaze
@ 2019-10-24 10:13 Michal Simek
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
  2019-10-24 17:03 ` [PATCH 0/2] Enabling MSI for Microblaze Waiman Long
  0 siblings, 2 replies; 6+ messages in thread
From: Michal Simek @ 2019-10-24 10:13 UTC (permalink / raw)
  To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman, helgaas
  Cc: Catalin Marinas, Eric Biggers, Peter Zijlstra \(Intel\),
	Benjamin Herrenschmidt, linux-pci, Masahiro Yamada,
	Paul Mackerras, sparclinux, linux-riscv, Will Deacon,
	Ingo Molnar, linux-arch, Herbert Xu, Michael Ellerman,
	Jackie Liu, Russell King, Firoz Khan, Wesley Terpstra,
	James Hogan, linux-snps-arc, Albert Ou, Arnd Bergmann,
	Paul Walmsley, Bjorn Helgaas, linux-arm-kernel, Ard Biesheuvel,
	Greg Kroah-Hartman, Cornelia Huck, linux-mips, Ralf Baechle,
	Paul Burton, Vineet Gupta, Paolo Bonzini, linuxppc-dev,
	David S. Miller

Hi,

these two patches come from discussion with Christoph, Bjorn, Palmer and
Waiman. The first patch was suggestion by Christoph here
https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
The second part was discussed
https://lore.kernel.org/linux-pci/mhng-5d9bcb53-225e-441f-86cc-b335624b3e7c@palmer-si-x1e/
and
https://lore.kernel.org/linux-pci/20191017181937.7004-1-palmer@sifive.com/

Thanks,
Michal


Michal Simek (1):
  asm-generic: Make msi.h a mandatory include/asm header

Palmer Dabbelt (1):
  pci: Default to PCI_MSI_IRQ_DOMAIN

 arch/arc/include/asm/Kbuild     | 1 -
 arch/arm/include/asm/Kbuild     | 1 -
 arch/arm64/include/asm/Kbuild   | 1 -
 arch/mips/include/asm/Kbuild    | 1 -
 arch/powerpc/include/asm/Kbuild | 1 -
 arch/riscv/include/asm/Kbuild   | 1 -
 arch/sparc/include/asm/Kbuild   | 1 -
 drivers/pci/Kconfig             | 2 +-
 include/asm-generic/Kbuild      | 1 +
 9 files changed, 2 insertions(+), 8 deletions(-)

-- 
2.17.1


_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 10:13 [PATCH 0/2] Enabling MSI for Microblaze Michal Simek
@ 2019-10-24 10:13 ` Michal Simek
  2019-10-24 14:44   ` Masahiro Yamada
  2019-10-24 15:17   ` Paul Walmsley
  2019-10-24 17:03 ` [PATCH 0/2] Enabling MSI for Microblaze Waiman Long
  1 sibling, 2 replies; 6+ messages in thread
From: Michal Simek @ 2019-10-24 10:13 UTC (permalink / raw)
  To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman, helgaas
  Cc: Catalin Marinas, Eric Biggers, Peter Zijlstra \(Intel\),
	Benjamin Herrenschmidt, Masahiro Yamada, Paul Mackerras,
	sparclinux, linux-riscv, Will Deacon, Ingo Molnar, linux-arch,
	Herbert Xu, Michael Ellerman, Jackie Liu, Russell King,
	Firoz Khan, Wesley Terpstra, James Hogan, linux-snps-arc,
	Albert Ou, Arnd Bergmann, Paul Walmsley, linux-arm-kernel,
	Ard Biesheuvel, Greg Kroah-Hartman, Cornelia Huck, linux-mips,
	Ralf Baechle, Paul Burton, Vineet Gupta, Paolo Bonzini,
	linuxppc-dev, David S. Miller

msi.h is generic for all architectures expect of x86 which has own version.
Enabling MSI by including msi.h to architecture Kbuild is just additional
step which doesn't need to be done.
The patch was created based on request to enable MSI for Microblaze.

Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
---
 arch/arc/include/asm/Kbuild     | 1 -
 arch/arm/include/asm/Kbuild     | 1 -
 arch/arm64/include/asm/Kbuild   | 1 -
 arch/mips/include/asm/Kbuild    | 1 -
 arch/powerpc/include/asm/Kbuild | 1 -
 arch/riscv/include/asm/Kbuild   | 1 -
 arch/sparc/include/asm/Kbuild   | 1 -
 include/asm-generic/Kbuild      | 1 +
 8 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
index 393d4f5e1450..1b505694691e 100644
--- a/arch/arc/include/asm/Kbuild
+++ b/arch/arc/include/asm/Kbuild
@@ -17,7 +17,6 @@ generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
-generic-y += msi.h
 generic-y += parport.h
 generic-y += percpu.h
 generic-y += preempt.h
diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
index 68ca86f85eb7..fa579b23b4df 100644
--- a/arch/arm/include/asm/Kbuild
+++ b/arch/arm/include/asm/Kbuild
@@ -12,7 +12,6 @@ generic-y += local.h
 generic-y += local64.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
-generic-y += msi.h
 generic-y += parport.h
 generic-y += preempt.h
 generic-y += seccomp.h
diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild
index 98a5405c8558..bd23f87d6c55 100644
--- a/arch/arm64/include/asm/Kbuild
+++ b/arch/arm64/include/asm/Kbuild
@@ -16,7 +16,6 @@ generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
-generic-y += msi.h
 generic-y += qrwlock.h
 generic-y += qspinlock.h
 generic-y += serial.h
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
index c8b595c60910..61b0fc2026e6 100644
--- a/arch/mips/include/asm/Kbuild
+++ b/arch/mips/include/asm/Kbuild
@@ -13,7 +13,6 @@ generic-y += irq_work.h
 generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
-generic-y += msi.h
 generic-y += parport.h
 generic-y += percpu.h
 generic-y += preempt.h
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 64870c7be4a3..17726f2e46de 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -10,4 +10,3 @@ generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += preempt.h
 generic-y += vtime.h
-generic-y += msi.h
diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
index 16970f246860..1efaeddf1e4b 100644
--- a/arch/riscv/include/asm/Kbuild
+++ b/arch/riscv/include/asm/Kbuild
@@ -22,7 +22,6 @@ generic-y += kvm_para.h
 generic-y += local.h
 generic-y += local64.h
 generic-y += mm-arch-hooks.h
-generic-y += msi.h
 generic-y += percpu.h
 generic-y += preempt.h
 generic-y += sections.h
diff --git a/arch/sparc/include/asm/Kbuild b/arch/sparc/include/asm/Kbuild
index b6212164847b..62de2eb2773d 100644
--- a/arch/sparc/include/asm/Kbuild
+++ b/arch/sparc/include/asm/Kbuild
@@ -18,7 +18,6 @@ generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
 generic-y += module.h
-generic-y += msi.h
 generic-y += preempt.h
 generic-y += serial.h
 generic-y += trace_clock.h
diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
index adff14fcb8e4..ddfee1bd9dc1 100644
--- a/include/asm-generic/Kbuild
+++ b/include/asm-generic/Kbuild
@@ -4,4 +4,5 @@
 # (This file is not included when SRCARCH=um since UML borrows several
 # asm headers from the host architecutre.)
 
+mandatory-y += msi.h
 mandatory-y += simd.h
-- 
2.17.1


_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
@ 2019-10-24 14:44   ` Masahiro Yamada
  2019-10-25  6:12     ` Michal Simek
  2019-10-24 15:17   ` Paul Walmsley
  1 sibling, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2019-10-24 14:44 UTC (permalink / raw)
  To: Michal Simek
  Cc: Benjamin Herrenschmidt, Eric Biggers, Peter Zijlstra \(Intel\),
	Catalin Marinas, Palmer Dabbelt, linux-mips, Paul Mackerras,
	sparclinux, linux-riscv, Will Deacon, Ingo Molnar, linux-arch,
	Herbert Xu, Michael Ellerman, Jackie Liu, Russell King,
	Christoph Hellwig, Firoz Khan, Wesley Terpstra, James Hogan,
	Bjorn Helgaas, arcml, Albert Ou, Arnd Bergmann, git,
	Paul Walmsley, longman, linux-arm-kernel, Michal Simek,
	Ard Biesheuvel, Vineet Gupta, Cornelia Huck,
	Linux Kernel Mailing List, Ralf Baechle, Paul Burton,
	Greg Kroah-Hartman, Paolo Bonzini, linuxppc-dev, David S. Miller

On Thu, Oct 24, 2019 at 7:13 PM Michal Simek <michal.simek@xilinx.com> wrote:
>
> msi.h is generic for all architectures expect of x86 which has own version.

Maybe a typo?  "except"


Anyway, the code looks good to me.

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


> Enabling MSI by including msi.h to architecture Kbuild is just additional
> step which doesn't need to be done.
> The patch was created based on request to enable MSI for Microblaze.
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
> ---
>  arch/arc/include/asm/Kbuild     | 1 -
>  arch/arm/include/asm/Kbuild     | 1 -
>  arch/arm64/include/asm/Kbuild   | 1 -
>  arch/mips/include/asm/Kbuild    | 1 -
>  arch/powerpc/include/asm/Kbuild | 1 -
>  arch/riscv/include/asm/Kbuild   | 1 -
>  arch/sparc/include/asm/Kbuild   | 1 -
>  include/asm-generic/Kbuild      | 1 +
>  8 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
> index 393d4f5e1450..1b505694691e 100644
> --- a/arch/arc/include/asm/Kbuild
> +++ b/arch/arc/include/asm/Kbuild
> @@ -17,7 +17,6 @@ generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
> -generic-y += msi.h
>  generic-y += parport.h
>  generic-y += percpu.h
>  generic-y += preempt.h
> diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
> index 68ca86f85eb7..fa579b23b4df 100644
> --- a/arch/arm/include/asm/Kbuild
> +++ b/arch/arm/include/asm/Kbuild
> @@ -12,7 +12,6 @@ generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
> -generic-y += msi.h
>  generic-y += parport.h
>  generic-y += preempt.h
>  generic-y += seccomp.h
> diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild
> index 98a5405c8558..bd23f87d6c55 100644
> --- a/arch/arm64/include/asm/Kbuild
> +++ b/arch/arm64/include/asm/Kbuild
> @@ -16,7 +16,6 @@ generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
> -generic-y += msi.h
>  generic-y += qrwlock.h
>  generic-y += qspinlock.h
>  generic-y += serial.h
> diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
> index c8b595c60910..61b0fc2026e6 100644
> --- a/arch/mips/include/asm/Kbuild
> +++ b/arch/mips/include/asm/Kbuild
> @@ -13,7 +13,6 @@ generic-y += irq_work.h
>  generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
> -generic-y += msi.h
>  generic-y += parport.h
>  generic-y += percpu.h
>  generic-y += preempt.h
> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
> index 64870c7be4a3..17726f2e46de 100644
> --- a/arch/powerpc/include/asm/Kbuild
> +++ b/arch/powerpc/include/asm/Kbuild
> @@ -10,4 +10,3 @@ generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += preempt.h
>  generic-y += vtime.h
> -generic-y += msi.h
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 16970f246860..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += kvm_para.h
>  generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
> -generic-y += msi.h
>  generic-y += percpu.h
>  generic-y += preempt.h
>  generic-y += sections.h
> diff --git a/arch/sparc/include/asm/Kbuild b/arch/sparc/include/asm/Kbuild
> index b6212164847b..62de2eb2773d 100644
> --- a/arch/sparc/include/asm/Kbuild
> +++ b/arch/sparc/include/asm/Kbuild
> @@ -18,7 +18,6 @@ generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
>  generic-y += module.h
> -generic-y += msi.h
>  generic-y += preempt.h
>  generic-y += serial.h
>  generic-y += trace_clock.h
> diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
> index adff14fcb8e4..ddfee1bd9dc1 100644
> --- a/include/asm-generic/Kbuild
> +++ b/include/asm-generic/Kbuild
> @@ -4,4 +4,5 @@
>  # (This file is not included when SRCARCH=um since UML borrows several
>  # asm headers from the host architecutre.)
>
> +mandatory-y += msi.h
>  mandatory-y += simd.h
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
  2019-10-24 14:44   ` Masahiro Yamada
@ 2019-10-24 15:17   ` Paul Walmsley
  1 sibling, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2019-10-24 15:17 UTC (permalink / raw)
  To: Michal Simek
  Cc: Benjamin Herrenschmidt, Eric Biggers, Peter Zijlstra \(Intel\),
	Catalin Marinas, palmer, linux-mips, Masahiro Yamada,
	Paul Mackerras, sparclinux, linux-riscv, Will Deacon,
	Ingo Molnar, linux-arch, Herbert Xu, Michael Ellerman,
	Jackie Liu, Russell King, hch, Firoz Khan, Wesley Terpstra,
	James Hogan, helgaas, linux-snps-arc, Albert Ou, Arnd Bergmann,
	git, longman, linux-arm-kernel, monstr, Ard Biesheuvel,
	Vineet Gupta, Cornelia Huck, linux-kernel, Ralf Baechle,
	Paul Burton, Greg Kroah-Hartman, Paolo Bonzini, linuxppc-dev,
	David S. Miller

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Thu, 24 Oct 2019, Michal Simek wrote:

> msi.h is generic for all architectures expect of x86 which has own version.
> Enabling MSI by including msi.h to architecture Kbuild is just additional
> step which doesn't need to be done.
> The patch was created based on request to enable MSI for Microblaze.
> 
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/

[ ... ]

> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 16970f246860..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += kvm_para.h
>  generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
> -generic-y += msi.h
>  generic-y += percpu.h
>  generic-y += preempt.h
>  generic-y += sections.h

Acked-by: Paul Walmsley <paul.walmsley@sifive.com> # arch/riscv
Tested-by: Paul Walmsley <paul.walmsley@sifive.com> # build only, rv32/rv64

Thanks Michał,


- Paul

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Enabling MSI for Microblaze
  2019-10-24 10:13 [PATCH 0/2] Enabling MSI for Microblaze Michal Simek
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
@ 2019-10-24 17:03 ` Waiman Long
  1 sibling, 0 replies; 6+ messages in thread
From: Waiman Long @ 2019-10-24 17:03 UTC (permalink / raw)
  To: Michal Simek, linux-kernel, monstr, git, palmer, hch, helgaas
  Cc: Catalin Marinas, Eric Biggers, Peter Zijlstra \(Intel\),
	Benjamin Herrenschmidt, linux-pci, Masahiro Yamada,
	Paul Mackerras, sparclinux, linux-riscv, Will Deacon,
	Ingo Molnar, linux-arch, Herbert Xu, Michael Ellerman,
	Jackie Liu, Russell King, Firoz Khan, Wesley Terpstra,
	James Hogan, linux-snps-arc, Albert Ou, Arnd Bergmann,
	Paul Walmsley, Bjorn Helgaas, linux-arm-kernel, Ard Biesheuvel,
	Greg Kroah-Hartman, Cornelia Huck, linux-mips, Ralf Baechle,
	Paul Burton, Vineet Gupta, Paolo Bonzini, linuxppc-dev,
	David S. Miller

On 10/24/19 6:13 AM, Michal Simek wrote:
> Hi,
>
> these two patches come from discussion with Christoph, Bjorn, Palmer and
> Waiman. The first patch was suggestion by Christoph here
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
> The second part was discussed
> https://lore.kernel.org/linux-pci/mhng-5d9bcb53-225e-441f-86cc-b335624b3e7c@palmer-si-x1e/
> and
> https://lore.kernel.org/linux-pci/20191017181937.7004-1-palmer@sifive.com/
>
> Thanks,
> Michal
>
>
> Michal Simek (1):
>   asm-generic: Make msi.h a mandatory include/asm header
>
> Palmer Dabbelt (1):
>   pci: Default to PCI_MSI_IRQ_DOMAIN
>
>  arch/arc/include/asm/Kbuild     | 1 -
>  arch/arm/include/asm/Kbuild     | 1 -
>  arch/arm64/include/asm/Kbuild   | 1 -
>  arch/mips/include/asm/Kbuild    | 1 -
>  arch/powerpc/include/asm/Kbuild | 1 -
>  arch/riscv/include/asm/Kbuild   | 1 -
>  arch/sparc/include/asm/Kbuild   | 1 -
>  drivers/pci/Kconfig             | 2 +-
>  include/asm-generic/Kbuild      | 1 +
>  9 files changed, 2 insertions(+), 8 deletions(-)
>
That looks OK.

Acked-by: Waiman Long <longman@redhat.com>


_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 14:44   ` Masahiro Yamada
@ 2019-10-25  6:12     ` Michal Simek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2019-10-25  6:12 UTC (permalink / raw)
  To: Masahiro Yamada, Michal Simek
  Cc: Benjamin Herrenschmidt, Eric Biggers, Peter Zijlstra \(Intel\),
	Catalin Marinas, Palmer Dabbelt, linux-mips, Paul Mackerras,
	longman, sparclinux, linux-riscv, Will Deacon, Ingo Molnar,
	linux-arch, Herbert Xu, Michael Ellerman, Jackie Liu,
	Russell King, Christoph Hellwig, Firoz Khan, Wesley Terpstra,
	James Hogan, Bjorn Helgaas, arcml, Albert Ou, Arnd Bergmann, git,
	Paul Walmsley, linux-arm-kernel, Ard Biesheuvel, Vineet Gupta,
	Cornelia Huck, Linux Kernel Mailing List, Ralf Baechle,
	Paul Burton, Greg Kroah-Hartman, Paolo Bonzini, linuxppc-dev,
	David S. Miller

On 24. 10. 19 16:44, Masahiro Yamada wrote:
> On Thu, Oct 24, 2019 at 7:13 PM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> msi.h is generic for all architectures expect of x86 which has own version.
> 
> Maybe a typo?  "except"

unfortunately yes.

> 
> 
> Anyway, the code looks good to me.
> 
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>

I have sent v2.
Who should be taking these patches?

Thanks,
Michal

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 10:13 [PATCH 0/2] Enabling MSI for Microblaze Michal Simek
2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
2019-10-24 14:44   ` Masahiro Yamada
2019-10-25  6:12     ` Michal Simek
2019-10-24 15:17   ` Paul Walmsley
2019-10-24 17:03 ` [PATCH 0/2] Enabling MSI for Microblaze Waiman Long

Linux SNPS ARC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-snps-arc/0 linux-snps-arc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-snps-arc linux-snps-arc/ https://lore.kernel.org/linux-snps-arc \
		linux-snps-arc@lists.infradead.org
	public-inbox-index linux-snps-arc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-snps-arc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git