From: "Arnd Bergmann" <arnd@arndb.de>
To: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Helge Deller" <deller@gmx.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Vineet Gupta" <vgupta@kernel.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"David S . Miller" <davem@davemloft.net>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Sam Ravnborg" <sam@ravnborg.org>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org, loongarch@lists.linux.dev,
linux-m68k@lists.linux-m68k.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH v4 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h>
Date: Thu, 04 May 2023 10:08:05 +0200 [thread overview]
Message-ID: <ee4cea3d-282e-4e90-897e-4ba576731f6e@app.fastmail.com> (raw)
In-Reply-To: <20230504074539.8181-1-tzimmermann@suse.de>
On Thu, May 4, 2023, at 09:45, Thomas Zimmermann wrote:
> Fbdev provides helpers for framebuffer I/O, such as fb_readl(),
> fb_writel() or fb_memcpy_to_fb(). The implementation of each helper
> depends on the architecture, but they are all equivalent to regular
> I/O functions of similar names. So use regular functions instead and
> move all helpers into <asm-generic/fb.h>
>
> The first patch a simple whitespace cleanup.
>
> Until now, <linux/fb.h> contained an include of <asm/io.h>. As this
> will go away, patches 2 to 4 prepare include statements in the various
> drivers. Source files that use regular I/O helpers, such as readl(),
> now include <linux/io.h>. Source files that use framebuffer I/O
> helpers, such as fb_readl(), now include <linux/fb.h>.
>
> Patch 5 replaces the architecture-based if-else branching in
> <linux/fb.h> by helpers in <asm-generic/fb.h>. All helpers use Linux'
> existing I/O functions.
>
> Patch 6 harmonizes naming among fbdev and existing I/O functions.
>
> The patchset has been built for a variety of platforms, such as x86-64,
> arm, aarch64, ppc64, parisc, m64k, mips and sparc.
The whole series looks good to me now,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2023-05-04 8:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 7:45 [PATCH v4 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 1/6] fbdev/matrox: Remove trailing whitespaces Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 2/6] ipu-v3: Include <linux/io.h> Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 3/6] fbdev: Include <linux/io.h> in various drivers Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 4/6] fbdev: Include <linux/fb.h> instead of <asm/fb.h> Thomas Zimmermann
2023-05-04 15:37 ` Sam Ravnborg
2023-05-05 7:02 ` Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 5/6] fbdev: Move framebuffer I/O helpers into <asm/fb.h> Thomas Zimmermann
[not found] ` <d4930b1a-d79e-6deb-6683-f13bbe1170ff@189.cn>
2023-05-05 6:59 ` [v4,5/6] " Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 6/6] fbdev: Rename fb_mem*() helpers Thomas Zimmermann
2023-05-04 8:08 ` Arnd Bergmann [this message]
2023-05-05 7:01 ` [PATCH v4 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4cea3d-282e-4e90-897e-4ba576731f6e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=chenhuacai@kernel.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).