From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@kernel.org
Subject: Re: [PATCH] ALSA: hda: intel-sdw-acpi: fix usage of device_get_named_child_node()
Date: Mon, 29 Apr 2024 10:15:19 -0500 [thread overview]
Message-ID: <8c87a931-9e9b-4922-a126-867da5e0b3df@linux.intel.com> (raw)
In-Reply-To: <874jbkp5zz.wl-tiwai@suse.de>
Hi Takashi,
>> The documentation for device_get_named_child_node() mentions this
>> important point:
>>
>> "
>> The caller is responsible for calling fwnode_handle_put() on the
>> returned fwnode pointer.
>> "
>>
>> Add fwnode_handle_put() to avoid a leaked reference.
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Can we have a corresponding Fixes tag?
Good question.
The initial code was in
6d2c66695bf3 ("soundwire: intel: transition to 3 steps initialization")
but then moved with
08c2a4bc9f2a ("ALSA: hda: move Intel SoundWire ACPI scan to dedicated
module")
I guess a Fixes tag for the latter is good enough, it's a 2021 commit
and that would probably cover most SoundWire platforms.
next prev parent reply other threads:[~2024-04-29 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 15:27 [PATCH] ALSA: hda: intel-sdw-acpi: fix usage of device_get_named_child_node() Pierre-Louis Bossart
2024-04-29 15:01 ` Takashi Iwai
2024-04-29 15:15 ` Pierre-Louis Bossart [this message]
2024-04-29 15:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c87a931-9e9b-4922-a126-867da5e0b3df@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).