From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/7] builtin: use a table for the builtins
Date: Fri, 12 Jun 2020 18:48:32 +0200 [thread overview]
Message-ID: <20200612164832.fkkfvqcbjh7ivea7@ltop.local> (raw)
In-Reply-To: <62b18141-89be-d0e0-a848-8cf096d0f160@ramsayjones.plus.com>
On Fri, Jun 12, 2020 at 01:56:20AM +0100, Ramsay Jones wrote:
> On 10/06/2020 21:27, Luc Van Oostenryck wrote:
> >
> > A table is table is preferable but a complication for doing this
>
> s/table is table is/table is/
Thanks for noticing this typo (and the ones in the other patches).
> > +static void declare_one_builtin(const struct builtin_fn *entry)
> > +{
> > + struct symbol *sym = create_symbol(0, entry->name, SYM_NODE, NS_SYMBOL);
>
> So, assuming stream 0 here as well ...
>
> > -static void declare_builtin(const char *name, struct symbol *rtype, int variadic, ...)
> > -{
> > - int stream = 0; // FIXME
>
> ... and, yes, here is the FIXME (so my memory is not as bad
> as I thought!).
>
> This all looks good.
Well yes ... I don't really like the situation, though.
I probably should do something like adding a #define builtin_stream 0
and use this.
Thnaks to bring my attention to this.
-- Luc
next prev parent reply other threads:[~2020-06-12 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 20:27 [PATCH 0/7] move arch-specific builtins to their own table Luc Van Oostenryck
2020-06-10 20:27 ` [PATCH 1/7] builtin: can be initialized later Luc Van Oostenryck
2020-06-12 0:50 ` Ramsay Jones
2020-06-10 20:27 ` [PATCH 2/7] builtin: use a table for the builtins Luc Van Oostenryck
2020-06-12 0:56 ` Ramsay Jones
2020-06-12 16:48 ` Luc Van Oostenryck [this message]
2020-06-10 20:27 ` [PATCH 3/7] builtin: unify the 2 tables of builtins Luc Van Oostenryck
2020-06-12 1:01 ` Ramsay Jones
2020-06-10 20:27 ` [PATCH 4/7] builtin: add support for arch-specific builtins Luc Van Oostenryck
2020-06-10 20:27 ` [PATCH 5/7] arch: add specificities for Nios2 Luc Van Oostenryck
2020-06-12 1:04 ` Ramsay Jones
2020-06-12 17:04 ` Luc Van Oostenryck
2020-06-10 20:27 ` [PATCH 6/7] arch: add specificities for Blackfin Luc Van Oostenryck
2020-06-10 20:27 ` [PATCH 7/7] arch: add specificities for Alpha Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612164832.fkkfvqcbjh7ivea7@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).