From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH] printk: Make linux/printk.h self-contained Date: Sat, 13 Jun 2020 23:09:49 +1000 Message-ID: <20200613130949.GA22005@gondor.apana.org.au> References: <20200611125144.GA2506@gondor.apana.org.au> <20200613122834.GA23739@xsang-OptiPlex-9020> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from helcar.hmeau.com ([216.24.177.18]:42472 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgFMNKN (ORCPT ); Sat, 13 Jun 2020 09:10:13 -0400 Content-Disposition: inline In-Reply-To: <20200613122834.GA23739@xsang-OptiPlex-9020> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: kernel test robot , linux-sparse@vger.kernel.org Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linux Kernel Mailing List , kbuild-all@lists.01.org On Sat, Jun 13, 2020 at 08:28:34PM +0800, kernel test robot wrote: > > Hi Herbert, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.7 next-20200611] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Herbert-Xu/printk-Make-linux-printk-h-self-contained/20200611-205340 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b29482fde649c72441d5478a4ea2c52c56d97a5e > :::::: branch date: 13 hours ago > :::::: commit date: 13 hours ago > config: powerpc-randconfig-s031-20200611 (attached as .config) > compiler: powerpc64le-linux-gcc (GCC) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.1-250-g42323db3-dirty > # save the attached .config to linux build tree > make W=1 C=1 ARCH=powerpc CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > sparse warnings: (new ones prefixed by >>) > > >> include/linux/ratelimit_types.h:16:25: sparse: sparse: expected ; at end of declaration > include/linux/ratelimit_types.h:16:25: sparse: sparse: Expected } at end of struct-union-enum-specifier > include/linux/ratelimit_types.h:16:25: sparse: sparse: got lock > include/linux/ratelimit_types.h:24:1: sparse: sparse: Expected ; at the end of type declaration > include/linux/ratelimit_types.h:24:1: sparse: sparse: got } This looks like a bug in sparse as the same code compiles just fine. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt