From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 2/5] gensel: use temporary variable in generic selection
Date: Fri, 19 Jun 2020 17:02:57 +0200 [thread overview]
Message-ID: <20200619150300.63695-3-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20200619150300.63695-1-luc.vanoostenryck@gmail.com>
Use a temporary variable for 'map->type' to make the expressions
in the following patches more readable.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
evaluate.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/evaluate.c b/evaluate.c
index 95aef4dc0758..cf40eed418b4 100644
--- a/evaluate.c
+++ b/evaluate.c
@@ -3293,9 +3293,11 @@ static struct symbol *evaluate_generic_selection(struct expression *expr)
return NULL;
for (map = expr->map; map; map = map->next) {
- if (!evaluate_symbol(map->type))
+ struct symbol *stype = map->type;
+
+ if (!evaluate_symbol(stype))
continue;
- if (!type_selection(ctrl, map->type))
+ if (!type_selection(ctrl, stype))
continue;
res = map->expr;
--
2.27.0
next prev parent reply other threads:[~2020-06-19 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 15:02 [PATCH 0/5] Fixes for generic selection Luc Van Oostenryck
2020-06-19 15:02 ` [PATCH 1/5] gensel: add testcases from DR481 Luc Van Oostenryck
2020-06-19 15:02 ` Luc Van Oostenryck [this message]
2020-06-19 15:02 ` [PATCH 3/5] gensel: controlling expression must be lvalue converted Luc Van Oostenryck
2020-06-19 15:02 ` [PATCH 4/5] gensel: controlling expression must be pointer-converted Luc Van Oostenryck
2020-06-19 15:03 ` [PATCH 5/5] gensel: validate the type of the associations Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619150300.63695-3-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).