* [PATCH] predef: simplify add_pre_buffer()
@ 2020-07-05 10:29 Luc Van Oostenryck
0 siblings, 0 replies; only message in thread
From: Luc Van Oostenryck @ 2020-07-05 10:29 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
pre_buffer_begin & pre_buffer_end are the head and the tail of
a singly chained list. As such, it's slightly easier to not
keep a pointer on the last element but a pointer where the
next element should be written.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
lib.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/lib.c b/lib.c
index e56788260cb7..863900b54c3c 100644
--- a/lib.c
+++ b/lib.c
@@ -248,7 +248,7 @@ void die(const char *fmt, ...)
}
static struct token *pre_buffer_begin = NULL;
-static struct token *pre_buffer_end = NULL;
+static struct token **pre_buffer_next = &pre_buffer_begin;
int Waddress = 0;
int Waddress_space = 1;
@@ -348,11 +348,8 @@ void add_pre_buffer(const char *fmt, ...)
size = vsnprintf(buffer, sizeof(buffer), fmt, args);
va_end(args);
begin = tokenize_buffer(buffer, size, &end);
- if (!pre_buffer_begin)
- pre_buffer_begin = begin;
- if (pre_buffer_end)
- pre_buffer_end->next = begin;
- pre_buffer_end = end;
+ *pre_buffer_next = begin;
+ pre_buffer_next = &end->next;
}
////////////////////////////////////////////////////////////////////////////////
--
2.27.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-05 10:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-05 10:29 [PATCH] predef: simplify add_pre_buffer() Luc Van Oostenryck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).