From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Alexey Gladkov <gladkov.alexey@gmail.com>, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] dissect: add support for _Generic
Date: Wed, 29 Jul 2020 01:10:58 +0200 [thread overview]
Message-ID: <20200728231058.3yakpfw3dqslxq5t@ltop.local> (raw)
In-Reply-To: <20200728194937.GA2467@redhat.com>
On Tue, Jul 28, 2020 at 09:49:38PM +0200, Oleg Nesterov wrote:
> On 07/28, Alexey Gladkov wrote:
> >
> > No special support needed for _Generic,
>
> Hmm. I am already sleeping and didn't read the _Generic code yet... but
> shouldn't dissect() inspect ->control/map/def?
>
> That said,
>
> > so just suppress the warning
> > about unknown type.
>
> probably better than nothing, lets shut up the warning first.
OK, since there is some urgency, I applied it directly but
my first reaction was also "eh, you can't just ignore
EXPR_GENERIC / pretend it's one of the top-level expression".
OTOH, I wonder what can be done without first evaluating
(the type of) the controlling expression and the types of the map
(if I understand correctly, evaluation is avoided in dissect).
-- Luc
next prev parent reply other threads:[~2020-07-28 23:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 18:35 [PATCH] dissect: add support for _Generic Alexey Gladkov
2020-07-28 19:49 ` Oleg Nesterov
2020-07-28 23:10 ` Luc Van Oostenryck [this message]
2020-07-29 11:28 ` Oleg Nesterov
2020-07-29 14:50 ` Luc Van Oostenryck
2020-07-30 15:08 ` Oleg Nesterov
2020-07-30 20:00 ` Luc Van Oostenryck
2020-07-31 14:43 ` Oleg Nesterov
2020-07-31 16:13 ` Luc Van Oostenryck
2020-07-30 15:09 ` [PATCH] dissect: support _Generic() a bit more Oleg Nesterov
2020-07-30 20:05 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728231058.3yakpfw3dqslxq5t@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=gladkov.alexey@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).