From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 7/8] add support for "%ls"
Date: Mon, 5 Oct 2020 04:00:01 +0200 [thread overview]
Message-ID: <20201005020002.1108-8-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20201005020002.1108-1-luc.vanoostenryck@gmail.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
verify-format.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/verify-format.c b/verify-format.c
index 95ff524c03cf..b27440b87c6b 100644
--- a/verify-format.c
+++ b/verify-format.c
@@ -77,7 +77,7 @@ static int printf_fmt_string(struct format_type *fmt,
struct symbol *ctype,
struct symbol **target, const char **typediff)
{
- *target = &const_string_ctype;
+ *target = fmt->type;
return check_assignment_types(*target, expr, typediff);
}
@@ -130,6 +130,7 @@ static struct format_type *parse_printf_get_fmt(struct format_type *type,
if (*ptr == 's') {
ptr++;
type->test = printf_fmt_string;
+ type->type = &const_string_ctype;
} else if (*ptr == 'c') {
ptr++;
type->test = printf_fmt_numtype;
@@ -231,6 +232,10 @@ static struct format_type *parse_printf_get_fmt(struct format_type *type,
type->test = printf_fmt_numtype;
type->type = szmod == 1 ? &ldouble_ctype : &double_ctype;
ptr++;
+ } else if (*ptr == 's') {
+ type->test = printf_fmt_string;
+ type->type = &const_wstring_ctype;
+ ptr++;
} else if (*ptr == 'n') { /* pointer to an de-referenced int/etc */
// todo - we should construct pointer to int/etc //
// also should not have any flags or widths for this
--
2.28.0
next prev parent reply other threads:[~2020-10-05 2:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 1:59 [PATCH 0/8] format check tweaks Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 1/8] need to strip SYM_NODE before comparing types Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 2/8] add helper get_nth_expression() Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 3/8] move the definition of FMT_{PRINTF,SCANF} Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 4/8] parse format attribute less verbosely Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 5/8] call verify_format_attribute() unconditionally Luc Van Oostenryck
2020-10-05 2:00 ` [PATCH 6/8] s/data/type/ for struct format_type Luc Van Oostenryck
2020-10-05 2:00 ` Luc Van Oostenryck [this message]
2020-10-05 2:00 ` [PATCH 8/8] add support for "%Lx" (and "%Ls") Luc Van Oostenryck
2020-10-05 9:04 ` [PATCH 0/8] format check tweaks Ben Dooks
2020-10-05 23:47 ` Luc Van Oostenryck
2020-10-11 19:51 ` Ben Dooks
2020-10-12 22:38 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005020002.1108-8-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).