linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/8] builtin: define a symbol_op for a generic op acting on integer
Date: Mon, 12 Apr 2021 00:05:13 +0200	[thread overview]
Message-ID: <20210411220513.plsj6wwv6o57phfq@mail> (raw)
In-Reply-To: <9bca36d1-b84a-7b6f-37cb-fd5285a86f0f@ramsayjones.plus.com>

On Sun, Apr 11, 2021 at 09:40:19PM +0100, Ramsay Jones wrote:
> On 10/04/2021 14:30, Luc Van Oostenryck wrote:
> > This can be used to define some generic (polymorphic) builtin
> > with a signature like:
> > 	op(T)
> > 	op(T, T)
> > 	op(T,T, ... T)
> > where T is some integer type.
> > 
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > ---
> >  builtin.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  builtin.h |  2 ++
> >  2 files changed, 52 insertions(+)
> > 
> > diff --git a/builtin.c b/builtin.c
> > index ff03dbab9a06..f03bf109c818 100644
> > --- a/builtin.c
> > +++ b/builtin.c
> > @@ -390,6 +390,56 @@ static struct symbol_op overflow_p_op = {
> >  };
> >  
> 
> I must apologize in advance, I've got a head cold, I'm tired and
> should probably not be commenting (especially since I am only
> skimming these patches), but ...

Sorry to hear this, and it's me that should apology, really.
This patch was a quick rough draft that I forget to return to it.
It's indeed very broken.

Thank you very much for noticing this.

-- Luc

  reply	other threads:[~2021-04-11 22:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 13:30 [PATCH 0/8] scheck: add a symbolic checker for sparse Luc Van Oostenryck
2021-04-10 13:30 ` [PATCH 1/8] export declare_builtins() Luc Van Oostenryck
2021-04-10 13:30 ` [PATCH 2/8] builtin: define a symbol_op for a generic op acting on integer Luc Van Oostenryck
2021-04-11 20:40   ` Ramsay Jones
2021-04-11 22:05     ` Luc Van Oostenryck [this message]
2021-04-10 13:30 ` [PATCH 3/8] .gitignore is a bit too greedy Luc Van Oostenryck
2021-04-10 13:30 ` [PATCH 4/8] scheck: add a symbolic checker Luc Van Oostenryck
2021-04-10 13:30 ` [PATCH 5/8] scheck: assert_eq() Luc Van Oostenryck
2021-04-10 13:30 ` [PATCH 6/8] scheck: allow multiple assertions Luc Van Oostenryck
2021-04-10 13:30 ` [PATCH 7/8] scheck: assert_const() Luc Van Oostenryck
2021-04-10 13:30 ` [PATCH 8/8] scheck: support pre-conditions via __assume() Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210411220513.plsj6wwv6o57phfq@mail \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).