From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH] sparse: only warn about directly nested flexible arrays
Date: Sat, 21 May 2022 14:32:18 +0200 [thread overview]
Message-ID: <20220521123218.6b455ktbumrgao6i@mail> (raw)
In-Reply-To: <20220111233959.2301120-1-jacob.e.keller@intel.com>
On Tue, Jan 11, 2022 at 03:39:59PM -0800, Jacob Keller wrote:
Hi,
Sorry for this long delay.
> Commit 02ed28909f3b ("flex-array: warn on flexible array in nested
> aggregate types") Introduced a new -Wflexible-array-nested warning which
> produces a warning when code nests a flexible array aggregate type
> within another aggregate type.
>
> This can produce warnings that are difficult to understand if this
> becomes nested. Consider the following example code:
>
> struct a {
> int i;
> long f[];
> };
>
> struct b {
> struct a a;
> };
>
> struct c {
> struct b b;
> };
>
> This will produce a warning both at struct b which directly embeds the
> struct a, and also at c which happens to include struct a recursively.
>
> It does not make sense to warn at the site of struct c. We already
> produce a warning at struct b! This just confuses users and can produce
> lots of extra warnings. Consider if struct b was part of some header
> and all of its users now see warnings for their usages like 'struct c'
> which now look like their fault, when the fault really lies with the
> definition of struct b.
>
> To avoid this, stop proliferating has_flexible_array so that the outer
> struct no longer produces a warning.
I fully agree with the feeling here but your patch would also disable
a warning for:
struct s_flex {
int i;
long f[];
};
union s {
struct s_flex flex;
char buf[200];
};
static union s a[2];
and catching arrays containing some flexible-array-member was one of
reasons to add the warning.
> This patch is a response to my query at
> https://lore.kernel.org/linux-sparse/64238376-3882-2449-7758-e948cb4a6e1c@intel.com/T/#u
I don't agree with everything you wrote there. For example, something like
"zero-sized flexible member" is meaningless to me (at least from a type
system PoV, which is what Sparse is all about) because a FAM has no (static)
size. It's just that struct tty_bufhead::sentinel.data will not (and must not!)
be used, but this won't be checkable.
> I think that proliferating this warning is unnecessary (since it will
> produce one warning at the exact point where we embed the structure already)
> and avoids confusing users of a header into thinking their code is at fault
> when its the code in the header at fault.
Yes, I fully agree.
I'll see in the coming days what can be done.
-- Luc
prev parent reply other threads:[~2022-05-21 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 23:39 [PATCH] sparse: only warn about directly nested flexible arrays Jacob Keller
2022-05-21 12:32 ` Luc Van Oostenryck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220521123218.6b455ktbumrgao6i@mail \
--to=luc.vanoostenryck@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).