From: Davidson Francis <davidsondfgl@gmail.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] test-inspect: reset locale after gtk_init()
Date: Sun, 5 Jul 2020 20:28:48 -0300 [thread overview]
Message-ID: <5f026233.1c69fb81.43be0.0187@mx.google.com> (raw)
In-Reply-To: <20200705203502.dwctpjxtqfwaz7bd@ltop.local>
On Sun, Jul 05, 2020 at 10:35:02PM +0200, Luc Van Oostenryck wrote:
> On Sun, Jul 05, 2020 at 12:12:55PM -0700, Linus Torvalds wrote:
> > It _might_ be a good idea to limit it to LC_NUMERIC instead of
> > LC_ALL,
> > but who knows.. I'm not sure what else might be affected (and I'm
> > not
> > sure how good LC_NUMERIC support is on all platforms)
>
> Well, checking the standard, I see that strtold() first strips
> whitespaces as defined by isspace() and isspace() itself depends
> on LC_CTYPE. So, for the moment, I prefer to take Davidson's
> patch as is this (OTOH, we already depend on isspace() anyway).
>
> -- Luc
I was also in doubt as to what would be the most appropriate
option. Anyway, thanks for accepting the patch.
Regards,
Davidson Francis.
prev parent reply other threads:[~2020-07-05 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 18:50 [PATCH] test-inspect: reset locale after gtk_init() Davidson Francis
2020-07-05 19:12 ` Linus Torvalds
2020-07-05 20:35 ` Luc Van Oostenryck
2020-07-05 23:28 ` Davidson Francis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f026233.1c69fb81.43be0.0187@mx.google.com \
--to=davidsondfgl@gmail.com \
--cc=20200705203502.dwctpjxtqfwaz7bd@ltop.local \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).