From: Linus Torvalds <torvalds@linux-foundation.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] RFC: problems with cast optimization at evaluation time
Date: Sat, 2 Jan 2021 11:52:37 -0800 [thread overview]
Message-ID: <CAHk-=wiYyR8gLPPBTwbDf97GiJLOH+EEQED7ARcXR2xyhK4r-w@mail.gmail.com> (raw)
In-Reply-To: <20210102100934.28459-1-luc.vanoostenryck@gmail.com>
On Sat, Jan 2, 2021 at 2:09 AM Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> It's easy enough to add a test to only allow this on 'true' integer types
> like done in the patch.
We already linearize casts to different ops for the different cases
(integer/pointer/fp/bool). So yeah, we should do it at that level.
> Again it's easy enough to add some checks but I wonder if all this
> is really worth.
I agree. Remove it from the evaluation phase, and add it to the
linearized SSA format instead.
Note that even on RISC architectures that don't even _have_ truncated
operations (ie an "add" or "not" is always done on the whole
register), doing the truncation to minimal bits is worth it, because
it ends up being just a "upper bits don't matter" and will remove a
_lot_ of sign-extension or zero-extension crud.
So I think the simplification should be done, but I agree it's done in
the wrong place.
Once you do it at the instruction simplification level, all of the
confusion goes away, because a "cast to floating point" is a
fundamentally different operation than "zero-extend integer" at that
level.
Linus
prev parent reply other threads:[~2021-01-02 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 10:09 [PATCH] RFC: problems with cast optimization at evaluation time Luc Van Oostenryck
2021-01-02 19:52 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiYyR8gLPPBTwbDf97GiJLOH+EEQED7ARcXR2xyhK4r-w@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).