From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Cc: "Guido Günther" <agx@sigxcpu.org>,
"Luc Van Oostenryck" <luc.vanoostenryck@gmail.com>,
"Sparse Mailing-list" <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register
Date: Sun, 14 Feb 2021 11:00:48 -0800 [thread overview]
Message-ID: <CAHk-=wjCAVj7J+KAC1pvtdeM-c76oXZq7k=v40-maKjTo6qfVw@mail.gmail.com> (raw)
In-Reply-To: <6a8eb07f-16d5-f461-cf0b-6c4aaf93b014@ramsayjones.plus.com>
On Sun, Feb 14, 2021 at 10:42 AM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> >
> > I looked around but didn't find any hints how to fix this. Any pointers
> > I missed (added the sparse list to cc:)?
>
> This is a limitation of sparse; when using the 'stringize' pre-processor
> operator #, the maximum size of the resulting string is about 8k (if I
> remember correctly).
Well, yes and no.
The C89 standard actually says that a string literal can be at most
509 characters to be portable. C99 increased it to 4095 characters.
Sparse makes the limit higher, and the limit could easily be expanded
way past 8kB - but the point is that large string literals are
actually not guaranteed to be valid C.
So honestly, it really sounds like that TRACE_EVENT() thing is doing
something it shouldn't be doing.
I don't think there's any fundamental limit why sparse does 8kB as a
limit (just a few random buffers). Making sparse accept larger ones
should be as simple as just increasing MAX_STRING, but I really don't
think the kernel should encourage that kind of excessive string sizes.
I wouldn't be surprised if tracing buffers etc make such strings useless anyway.
Linus
next prev parent reply other threads:[~2021-02-14 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <651ac50b9ff6ed3db8cab9f176514900f6a02a0c.1613131413.git.agx@sigxcpu.org>
[not found] ` <20210213031237.GP219708@shao2-debian>
2021-02-14 17:06 ` [PATCH v2 2/4] usb: typec: tps6598x: Add trace event for status register Guido Günther
2021-02-14 18:31 ` Ramsay Jones
2021-02-14 19:00 ` Linus Torvalds [this message]
2021-02-14 19:07 ` Linus Torvalds
2021-02-14 19:31 ` Ramsay Jones
2021-02-14 20:41 ` Luc Van Oostenryck
2021-02-15 11:32 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjCAVj7J+KAC1pvtdeM-c76oXZq7k=v40-maKjTo6qfVw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=agx@sigxcpu.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).