From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC3CC77B6C for ; Thu, 6 Apr 2023 21:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233746AbjDFVbi (ORCPT ); Thu, 6 Apr 2023 17:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233344AbjDFVbg (ORCPT ); Thu, 6 Apr 2023 17:31:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 931999749; Thu, 6 Apr 2023 14:31:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2ECBE63D8C; Thu, 6 Apr 2023 21:31:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71B66C4339B; Thu, 6 Apr 2023 21:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680816694; bh=HelVz4kZbXm+Rah9vhJsCLUNIR4bUm6nFIAmLLiqkbk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lYTjVd7ywbGnEhbcl/2fL2KfwQuymIsZ12J9dzXUJHlq2XaswYhR83+D5ASKktb3/ 1RlaEQyMvPpyMrgnCQTfuMEhat2SkkcDZ5rqGxtmshO5Qg92R0+DrE6uGRszPqz9KN iCI874zc0TPXflOIOAgvaTv9q2u/n7IPseMnVuoYp0KVWNIjYp+SfZo6hgxaloibjh cJHgr9ja/hY2Fd/7EwNWHt4iTji/qTjXuGd9YIvFyc4GDim43k8yWJX1YFRpS+DrVu Q49+reVSQKb6UxpQIQnzcb+LMJ9kkj3/G9BCxksEcD6R0T24Rf+OgBnW5TZRpRgvd+ Q9Q68OaYKr/1Q== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 12E164052D; Thu, 6 Apr 2023 18:31:32 -0300 (-03) Date: Thu, 6 Apr 2023 18:31:32 -0300 From: Arnaldo Carvalho de Melo To: "Liam R. Howlett" Cc: Miguel Ojeda , "linux-perf-users@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "llvm@lists.linux.dev" , "linux-sparse@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Mark Rutland , Miguel Ojeda , Rasmus Villemoes , Arnaldo Carvalho de Melo , Nathan Chancellor , Nick Desaulniers , Tom Rix Subject: Re: [PATCH] tools: Rename __fallthrough to fallthrough Message-ID: References: <20221125154947.2163498-1-Liam.Howlett@oracle.com> <20230406195830.ieiozetmk7qjllol@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org Em Thu, Apr 06, 2023 at 06:11:03PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Apr 06, 2023 at 10:02:57PM +0200, Miguel Ojeda escreveu: > > On Thu, Apr 6, 2023 at 9:58 PM Liam R. Howlett wrote: > > > > > > Any chance of this being accepted? I'm looking to use this in the radix > > > test suite and would rather not duplicate code. > > > > That would be up to the `tools/perf/` maintainers. > > Thanks, applied, So, I noticed some missing conversions, fixed that, but then when trying to test build it with: make -C tools/perf build-test I stumbled on this: make_with_gtk2: cd . && make GTK2=1 -j32 DESTDIR=/tmp/tmp.5AP8tPJgiT cd . && make GTK2=1 -j32 DESTDIR=/tmp/tmp.5AP8tPJgiT BUILD: Doing 'make -j32' parallel build HOSTCC fixdep.o HOSTLD fixdep-in.o CC trace/beauty/ioctl.o In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9, from /usr/include/glib-2.0/glib/gtypes.h:34, from /usr/include/glib-2.0/glib/galloca.h:34, from /usr/include/glib-2.0/glib.h:32, from /usr/include/glib-2.0/gobject/gbinding.h:30, from /usr/include/glib-2.0/glib-object.h:24, from /usr/include/glib-2.0/gio/gioenums.h:30, from /usr/include/glib-2.0/gio/giotypes.h:30, from /usr/include/glib-2.0/gio/gio.h:28, from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30, from /usr/include/gtk-2.0/gdk/gdk.h:32, from /usr/include/gtk-2.0/gtk/gtk.h:32, from ui/gtk/gtk.h:8, from ui/gtk/helpline.c:6: /usr/include/glib-2.0/glib/gmacros.h:637:28: error: missing ')' after "__has_attribute" 637 | #if g_macro__has_attribute(fallthrough) | ^~~~~~~~~~~ In file included from /var/home/acme/git/perf-tools-next/tools/include/linux/compiler_types.h:36, from /var/home/acme/git/perf-tools-next/tools/include/linux/compiler.h:5, from /var/home/acme/git/perf-tools-next/tools/include/linux/build_bug.h:5, from /var/home/acme/git/perf-tools-next/tools/include/linux/kernel.h:8, from ui/gtk/helpline.c:4: /var/home/acme/git/perf-tools-next/tools/include/linux/compiler-gcc.h:16:55: error: missing binary operator before token "(" 16 | # define fallthrough __attribute__((__fallthrough__)) | ^ /usr/include/glib-2.0/glib/gmacros.h:637:28: note: in expansion of macro ‘fallthrough’ 637 | #if g_macro__has_attribute(fallthrough) | ^~~~~~~~~~~ CC trace/beauty/kcmp.o CC bench/sched-messaging.o CC trace/beauty/mount_flags.o I'm trying to fix this now... - Arnaldo