From: Bart Van Assche <bvanassche@acm.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
linux-sparse@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/5] allow -1 and compares in bitwise types
Date: Mon, 27 Jun 2022 12:15:17 -0700 [thread overview]
Message-ID: <b306f11d-d2d8-3cab-ee4b-4e29acfd42ea@acm.org> (raw)
In-Reply-To: <20220627190540.13358-1-luc.vanoostenryck@gmail.com>
On 6/27/22 12:05, Luc Van Oostenryck wrote:
> Allow using -1 and compare operators with bitwise types
>
> This series is an experiment for allowing constants like
> -1 or ~0 with bitwise types, as well as using compares
> on them.
Will these changes cause sparse to stop complaining about
the following expression?
cpu_to_le32(1) < cpu_to_le32(2)
Shouldn't sparse keep complaining about the above expression?
> @Bart,
> Is there a good reason why the macro compares against 1 and
> not against 0?
Maybe to prevent that gcc or clang issues the following
warning: "warning: comparison of unsigned expression in ‘< 0’
is always false"?
Thanks,
Bart.
prev parent reply other threads:[~2022-06-27 19:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220623180528.3595304-1-bvanassche@acm.org>
[not found] ` <20220623180528.3595304-52-bvanassche@acm.org>
[not found] ` <20220624045613.GA4505@lst.de>
[not found] ` <aa044f61-46f0-5f21-9b17-a1bb1ff9c471@acm.org>
[not found] ` <20220625092349.GA23530@lst.de>
[not found] ` <3eed7994-8de2-324d-c373-b6f4289a2734@acm.org>
2022-06-26 9:58 ` [PATCH 51/51] fs/zonefs: Fix sparse warnings in tracing code Luc Van Oostenryck
2022-06-26 15:42 ` Bart Van Assche
2022-06-26 16:24 ` Luc Van Oostenryck
2022-06-26 16:33 ` Linus Torvalds
2022-06-26 16:50 ` Linus Torvalds
2022-06-26 20:10 ` Luc Van Oostenryck
2022-06-26 19:44 ` Luc Van Oostenryck
2022-06-27 19:05 ` [PATCH 0/5] allow -1 and compares in bitwise types Luc Van Oostenryck
2022-06-27 19:05 ` [PATCH 1/5] bitwise: add testcases Luc Van Oostenryck
2022-06-27 19:05 ` [PATCH 2/5] bitwise: accept all ones as non-restricted value Luc Van Oostenryck
2022-06-27 23:32 ` Ramsay Jones
2022-06-27 19:05 ` [PATCH 3/5] bitwise: allow compares for bitwise types Luc Van Oostenryck
2022-06-27 19:20 ` Linus Torvalds
2022-06-27 23:34 ` Ramsay Jones
2022-06-27 19:05 ` [PATCH 4/5] bitwise: do not remove the signedness of " Luc Van Oostenryck
2022-06-27 19:05 ` [PATCH 5/5] bitwise: early expansion of simple constants Luc Van Oostenryck
2022-06-27 19:14 ` [PATCH 0/5] allow -1 and compares in bitwise types Linus Torvalds
2022-06-27 19:15 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b306f11d-d2d8-3cab-ee4b-4e29acfd42ea@acm.org \
--to=bvanassche@acm.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).