[PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[Enrico Weigelt, metux IT consult]

Replace the GPLVv2 boilerplate w/ machine readable SPDX header.

Doing manual replacement, as rule 233 didn't fit exactly and would
have left empty comments.

Signed-off-by: Enrico Weigelt <info@metux.net>
---
 drivers/input/touchscreen/elants_i2c.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index f2cb231..f69de7b 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -10,7 +10,6 @@
  *  Copyright (c) 2010-2012 Benjamin Tissoires <benjamin.tissoires@gmail.com>
  *  Copyright (c) 2010-2012 Ecole Nationale de l'Aviation Civile, France
  *
- *
  * This code is partly based on i2c-hid.c:
  *
  * Copyright (c) 2012 Benjamin Tissoires <benjamin.tissoires@gmail.com>
@@ -18,12 +17,6 @@
  * Copyright (c) 2012 Red Hat, Inc
  */
 
-/*
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- */
-
 #include <linux/module.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
-- 
1.9.1

fixed: drivers: input: touchscreen: elants_i2c: Replace GPLv2

[Enrico Weigelt, metux IT consult]

uups, I've forgot the actual spdx header ... it's a pretty hot day :o
so, here's the fixed version.


--mtx

[PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[Enrico Weigelt, metux IT consult]

Replace the GPLVv2 boilerplate w/ machine readable SPDX header.

Doing manual replacement, as rule 233 didn't fit exactly and would
have left empty comments.

Signed-off-by: Enrico Weigelt <info@metux.net>
---
 drivers/input/touchscreen/elants_i2c.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index f2cb231..5c60061 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Elan Microelectronics touch panels with I2C interface
  *
@@ -10,7 +11,6 @@
  *  Copyright (c) 2010-2012 Benjamin Tissoires <benjamin.tissoires@gmail.com>
  *  Copyright (c) 2010-2012 Ecole Nationale de l'Aviation Civile, France
  *
- *
  * This code is partly based on i2c-hid.c:
  *
  * Copyright (c) 2012 Benjamin Tissoires <benjamin.tissoires@gmail.com>
@@ -18,12 +18,6 @@
  * Copyright (c) 2012 Red Hat, Inc
  */
 
-/*
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- */
-
 #include <linux/module.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
-- 
1.9.1

Re: [PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[Greg KH]

On Mon, Jun 03, 2019 at 12:40:44PM +0200, Enrico Weigelt, metux IT consult wrote:
> Replace the GPLVv2 boilerplate w/ machine readable SPDX header.
> 
> Doing manual replacement, as rule 233 didn't fit exactly and would
> have left empty comments.
> 
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
>  drivers/input/touchscreen/elants_i2c.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
> index f2cb231..f69de7b 100644
> --- a/drivers/input/touchscreen/elants_i2c.c
> +++ b/drivers/input/touchscreen/elants_i2c.c
> @@ -10,7 +10,6 @@
>   *  Copyright (c) 2010-2012 Benjamin Tissoires <benjamin.tissoires@gmail.com>
>   *  Copyright (c) 2010-2012 Ecole Nationale de l'Aviation Civile, France
>   *
> - *
>   * This code is partly based on i2c-hid.c:
>   *
>   * Copyright (c) 2012 Benjamin Tissoires <benjamin.tissoires@gmail.com>
> @@ -18,12 +17,6 @@
>   * Copyright (c) 2012 Red Hat, Inc
>   */
>  
> -/*
> - * This software is licensed under the terms of the GNU General Public
> - * License version 2, as published by the Free Software Foundation, and
> - * may be copied, distributed, and modified under those terms.
> - */

You can not just drop these lines and not put a proper SPDX line at the
same time :(

Re: [PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[Greg KH]

On Mon, Jun 03, 2019 at 12:49:03PM +0200, Enrico Weigelt, metux IT consult wrote:
> Replace the GPLVv2 boilerplate w/ machine readable SPDX header.
> 
> Doing manual replacement, as rule 233 didn't fit exactly and would
> have left empty comments.
> 
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
>  drivers/input/touchscreen/elants_i2c.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)

If this is a v2 patch, ALWAYS properly label it as such.

Otherwise I just get confused and delete all of the patches that are
different, yet have the identical subject lines :(

greg k-h

Re: [PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[Enrico Weigelt, metux IT consult]

On 03.06.19 13:37, Greg KH wrote:

> 
> You can not just drop these lines and not put a proper SPDX line at the
> same time :(

sorry, forgot it (getting a bit too much stellar radiation :o), but
already sent a fixed patch. did you receive it ?


--mtx


-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

Re: [PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[Enrico Weigelt, metux IT consult]

On 03.06.19 11:38, Greg KH wrote:
> On Mon, Jun 03, 2019 at 12:49:03PM +0200, Enrico Weigelt, metux IT consult wrote:
>> Replace the GPLVv2 boilerplate w/ machine readable SPDX header.
>>
>> Doing manual replacement, as rule 233 didn't fit exactly and would
>> have left empty comments.
>>
>> Signed-off-by: Enrico Weigelt <info@metux.net>
>> ---
>>   drivers/input/touchscreen/elants_i2c.c | 8 +-------
>>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> If this is a v2 patch, ALWAYS properly label it as such.
> 
> Otherwise I just get confused and delete all of the patches that are
> different, yet have the identical subject lines :(

Oh, sorry. I shouldn't send patches when I'm in a hurry :o
I'll repost it as v2 (unless the original one was already accepted).


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

Re: [PATCH] drivers: input: touchscreen: elants_i2c: Replace GPLv2 boilerplate/reference with SPDX

[Thomas Gleixner]

On Tue, 4 Jun 2019, Enrico Weigelt, metux IT consult wrote:

> On 03.06.19 11:38, Greg KH wrote:
> > On Mon, Jun 03, 2019 at 12:49:03PM +0200, Enrico Weigelt, metux IT consult
> > wrote:
> > > Replace the GPLVv2 boilerplate w/ machine readable SPDX header.
> > > 
> > > Doing manual replacement, as rule 233 didn't fit exactly and would
> > > have left empty comments.
> > > 
> > > Signed-off-by: Enrico Weigelt <info@metux.net>
> > > ---
> > >   drivers/input/touchscreen/elants_i2c.c | 8 +-------
> > >   1 file changed, 1 insertion(+), 7 deletions(-)
> > 
> > If this is a v2 patch, ALWAYS properly label it as such.
> > 
> > Otherwise I just get confused and delete all of the patches that are
> > different, yet have the identical subject lines :(
> 
> Oh, sorry. I shouldn't send patches when I'm in a hurry :o
> I'll repost it as v2 (unless the original one was already accepted).

As I said, I run the fixup script over it when collecting the patches from
the list.

Thanks,

	tglx