From: Qian Cai <cai@lca.pw>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>,
joe@perches.com, linux-spdx@archiver.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
rfontana@redhat.com, tglx@linutronix.de,
torvalds@linux-foundation.org, corbet@lwn.net,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v2] gpu/drm_memory: fix a few warnings
Date: Mon, 08 Jul 2019 15:41:59 -0400 [thread overview]
Message-ID: <1562614919.8510.9.camel@lca.pw> (raw)
In-Reply-To: <CAKb7UvhoW2F5LSf4B=vJhLykPCme_ixwbUBup_sBXjoQa72Fzw@mail.gmail.com>
On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote:
> On Mon, Jul 8, 2019 at 2:06 PM Qian Cai <cai@lca.pw> wrote:
> >
> > The opening comment mark "/**" is reserved for kernel-doc comments, so
> > it will generate a warning with "make W=1".
> >
> > drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand * \file
> > drm_memory.c
> >
> > Also, silence a checkpatch warning by adding a license identfiter where
> > it indicates the MIT license further down in the source file.
> >
> > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> >
> > It becomes redundant to add both an SPDX identifier and have a
> > description of the license in the comment block at the top, so remove
> > the later.
> >
> > Signed-off-by: Qian Cai <cai@lca.pw>
> > ---
> >
> > v2: remove the redundant description of the license.
> >
> > drivers/gpu/drm/drm_memory.c | 22 ++--------------------
> > 1 file changed, 2 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> > index 132fef8ff1b6..86a11fc8e954 100644
> > --- a/drivers/gpu/drm/drm_memory.c
> > +++ b/drivers/gpu/drm/drm_memory.c
> > @@ -1,4 +1,5 @@
> > -/**
> > +// SPDX-License-Identifier: MIT
> > +/*
> > * \file drm_memory.c
> > * Memory management wrappers for DRM
> > *
> > @@ -12,25 +13,6 @@
> > * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas.
> > * Copyright 2000 VA Linux Systems, Inc., Sunnyvale, California.
> > * All Rights Reserved.
> > - *
> > - * Permission is hereby granted, free of charge, to any person obtaining a
> > - * copy of this software and associated documentation files (the
> > "Software"),
> > - * to deal in the Software without restriction, including without
> > limitation
> > - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > - * and/or sell copies of the Software, and to permit persons to whom the
> > - * Software is furnished to do so, subject to the following conditions:
> > - *
> > - * The above copyright notice and this permission notice (including the
> > next
> > - * paragraph) shall be included in all copies or substantial portions of
> > the
> > - * Software.
> > - *
> > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> > OR
> > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> > - * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES
> > OR
>
> This talks about VA Linux Systems and/or its suppliers, while the MIT
> licence talks about authors or copyright holders.
>
> Are such transformations OK to just do?
From,
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Document
ation/process/license-rules.rst
"The Linux kernel requires the precise SPDX identifier in all source files."
That is the closest license I can think of.
Anyway, I have added a few people who may know better of the licensing.
>
> -ilia
>
> > - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> > - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > - * OTHER DEALINGS IN THE SOFTWARE.
> > */
> >
> > #include <linux/highmem.h>
> > --
> > 1.8.3.1
> >
next prev parent reply other threads:[~2019-07-08 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 18:05 [PATCH v2] gpu/drm_memory: fix a few warnings Qian Cai
2019-07-08 19:21 ` Ilia Mirkin
2019-07-08 19:41 ` Qian Cai [this message]
2019-07-08 19:57 ` Thomas Gleixner
2019-07-10 3:42 ` J Lovejoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562614919.8510.9.camel@lca.pw \
--to=cai@lca.pw \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=imirkin@alum.mit.edu \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@archiver.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=rfontana@redhat.com \
--cc=sean@poorly.run \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).