From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91EB7C742D2 for ; Fri, 12 Jul 2019 19:45:39 +0000 (UTC) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 401D2205C9 for ; Fri, 12 Jul 2019 19:45:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="fhr+GTL3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 401D2205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cai@lca.pw Received: by mail-qt1-f194.google.com with SMTP id z4so9361786qtc.3 for ; Fri, 12 Jul 2019 12:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=uf/ZSZSXNd4QAZJyCg9locUkKYy9cCURVXWZqnNb+h4=; b=fhr+GTL3qGOQfXrQWWqFVWvBS4bwFKmPchUELi37X6j/u6YTtA0VkzzeqDoZZszWqa VXWINnyqoH0rOyQ4OceOnDmfciKFiu3M/kVpu97MapdVfPuEwD6QrMBo1eGSif45N2p5 nTPRsJfraqQEZY4MRADP/nBCm8ck1ggciFJ7baFsm1mMUullBwllZt4EV8UMWrGmO3sZ dgQZsLBHFW0Se34Ur4qvoqig5bJ+ZfgTzNdzIBRScOwCYs/2KKW/QwHyutFKIRepSCDQ Lg6if/6uZOKfEHqCJcAGz5VJRWBTkUfu5NgT6+eEk50GvkdYlbzdZY6ZMKy/DzYS08LV zIEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=uf/ZSZSXNd4QAZJyCg9locUkKYy9cCURVXWZqnNb+h4=; b=Wi60Gc3xh2BsECKBh1HTcliVowgtjFWL2GhG8zao4Gsf/iVdIUnrJWfMnESaLhKa9a SQkLO3weZPIoJ78+P7LOA14W51ZHkJVr/hEarApZj2UbdjLWOdpp88sp5YFOn1ADt92z qzYe3ZUoqYWd+UyxGOWKPcNngHQUsnzIklAl46jYuASvpqr4f5LiQE6jtuMFr8az5W9y Z2v9ZQmw+7akg7QTu4Ca/yet2IkwtFiU7XIDep9zJEBJZdjuI6DSgLmwPc9ewOFYQ4KQ Fc25FMh6wFPlvROF1zaxqE6Lqctn0EI7h6w0mkjJb/Za6JiBhDFfF7ZsZthTPipvU7Ww +cOg== X-Gm-Message-State: APjAAAWB4ZiykIE/0IoBfzyzb3fGxkekSV5q/ZAr4+F2ldHawdE9CgcA BFX8n5kTAKnhSlKcoP6BAnK61g== X-Google-Smtp-Source: APXvYqzMEaiAFj63ZnaAYInlBZ2BCAScvRQzSk+eXQOGYKkHSBlgvbtnyLl0nyVIBFU9VX92RFcaWQ== X-Received: by 2002:a0c:e588:: with SMTP id t8mr8269608qvm.179.1562960738336; Fri, 12 Jul 2019 12:45:38 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id r14sm4632949qke.47.2019.07.12.12.45.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jul 2019 12:45:37 -0700 (PDT) Message-ID: <1562960735.8510.30.camel@lca.pw> Subject: Re: [PATCH v3] gpu/drm_memory: fix a few warnings From: Qian Cai To: akpm@linux-foundation.org Cc: imirkin@alum.mit.edu, airlied@linux.ie, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, sean@poorly.run, joe@perches.com, rfontana@redhat.com, tglx@linutronix.de, torvalds@linux-foundation.org, corbet@lwn.net, gregkh@linuxfoundation.org, linux-spdx@archiver.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Fri, 12 Jul 2019 15:45:35 -0400 In-Reply-To: <1562685190-1353-1-git-send-email-cai@lca.pw> References: <1562685190-1353-1-git-send-email-cai@lca.pw> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit about SPDX can pick this up. It occurs to me none of DRM maintainers cares about this as there is no feedback from any of them for months since v1. On Tue, 2019-07-09 at 11:13 -0400, Qian Cai wrote: > The opening comment mark "/**" is reserved for kernel-doc comments, so > it will generate a warning with "make W=1". > > drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand  * \file > drm_memory.c > > Also, silence a checkpatch warning by adding a license identfiter where > it indicates the MIT license further down in the source file. > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > Fix it by adding the MIT SPDX identifier without touching the boilerplate > language. > > Suggested-by: Thomas Gleixner > Signed-off-by: Qian Cai > --- > > v3: Keep the boilerplate language. > v2: Remove the redundant description of the license. > >  drivers/gpu/drm/drm_memory.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c > index 132fef8ff1b6..683042c8ee2c 100644 > --- a/drivers/gpu/drm/drm_memory.c > +++ b/drivers/gpu/drm/drm_memory.c > @@ -1,4 +1,5 @@ > -/** > +// SPDX-License-Identifier: MIT > +/* >   * \file drm_memory.c >   * Memory management wrappers for DRM >   *