From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A10C004C9 for ; Tue, 7 May 2019 18:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34BA7208C4 for ; Tue, 7 May 2019 18:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557252878; bh=mNf4T+QbRAY3EMSe01NQdmM2QIw3s/ghZnWP4n5KCwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Z/1i+bOde49n/pJM6S+UNGGk6q0oBYdD3zxFqxMFsL5E+q1unG336nM7pXRZNNhws CEnJpsJeRb9Mg5109nSBKaRte7Y1OxdNjflQpb3OqHjU4oz/6k1+XUmTH4EoFTzRxB IyQIpmv/Jw0rlbIuA0VqZlJnXLX8TdA27KgnXFxM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726572AbfEGSOi (ORCPT ); Tue, 7 May 2019 14:14:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:56722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbfEGSOh (ORCPT ); Tue, 7 May 2019 14:14:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5B2320825; Tue, 7 May 2019 18:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557252877; bh=mNf4T+QbRAY3EMSe01NQdmM2QIw3s/ghZnWP4n5KCwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nrt/HzcQ/J0wA7TrXu30ZD+Ai1QYJBnwigG3iM+w5l2IWBZ9p5G0GY+mpRLMOinNe +MvaltQJot9Edj03GMWvPcYJCRtEbtCg2zskoAFfhuxYTNwOtSTPwSBhaw0oGP17+u r+Ri0VtuWE3OcmzqKBJyF0ML18UxpQ4RiQV9xjg0= Date: Tue, 7 May 2019 20:14:35 +0200 From: Greg KH To: Thomas Gleixner Cc: linux-spdx@vger.kernel.org Subject: Re: [patch 0/4] SPDX: First batch of patches Message-ID: <20190507181435.GB13061@kroah.com> References: <20190507121952.495564307@linutronix.de> <20190507141746.GA28384@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Tue, May 07, 2019 at 04:19:35PM +0200, Thomas Gleixner wrote: > On Tue, 7 May 2019, Greg KH wrote: > > On Tue, May 07, 2019 at 02:19:52PM +0200, Thomas Gleixner wrote: > > > Hi! > > > > > > As promised here are the first 4 automatically generated patches. Each > > > patch handles exactly one match pattern (rule). > > > > > > While reviewing the patch (actual code change) might be massively time > > > consuming, the quick and important part is to look at the patterns and > > > verify whether the license conclusion is correct. The tooling which > > > replaces exactly those patterns is pretty solid by now. But if you really > > > insists on looking at each individual file change, you're welcome. :) > > > > > > Note that some of the patterns contain obscure things like: > > > > > > [no]_[pad]_[ctrl] > > > > > > in the middle. This one is a clear copy and paste artifact which happens to > > > be in arch/arm/mach-imx/iomux-mx35.h: > > > > > > * of the License, or (at your option, NO_PAD_CTRL) any later version. > > > > > > Oh well..... > > > > What's the diffstat of all 4 of these patches? How many files are you > > fixing up here? > > Oops. Forgot to add that. > > 305 files changed, 311 insertions(+), 2789 deletions(-) Nice, but I would have expected more files to be touched here :) Anyway, these all look good to me. I'm guessing the subject lines will be tweaked. If there's anything I can do to run the script and send out patches, please let me know. thanks, greg k-h