From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A44D7C004C9 for ; Tue, 7 May 2019 18:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 786B0206A3 for ; Tue, 7 May 2019 18:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557255500; bh=I1hjY5GTr14kZ+uYISJVPGiBOziwkaJrQE+RWbVD2Ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fC6kZKoyiRHdIsay2Aq8No08t4t4jfOUHGiCq0VsquL0RPFam3GBfbx2J5JBUdKq/ vkVqu10QPWQprLTp6dkAh5ZCktXQICmcNS6NZ5JSl0JwXBxnf4WJUC66AuL9Hfq5yJ yZ3qmTVsh15hZ+46MaWcfd7b7MelFZfSXEMzaAtg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726464AbfEGS6U (ORCPT ); Tue, 7 May 2019 14:58:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:41808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbfEGS6U (ORCPT ); Tue, 7 May 2019 14:58:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD52E20578; Tue, 7 May 2019 18:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557255499; bh=I1hjY5GTr14kZ+uYISJVPGiBOziwkaJrQE+RWbVD2Ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kd78j2OwEy3AdwXXQd2xqV/3rGfaDrTeOj8deeb5T+M6DLePbE5BY0Loi8DiyKuJ6 wje7pNMOi3xNoPwXtOxAZCU5Vay3knABH/9jPnAk8gneIGtw19HDa7Gl3CidTexfBt nFcwnRbTJogKefwxT+bjNWhTd/iRgaK4t6y/h+7Q= Date: Tue, 7 May 2019 20:58:17 +0200 From: Greg KH To: Thomas Gleixner Cc: linux-spdx@vger.kernel.org Subject: Re: [patch 0/4] SPDX: First batch of patches Message-ID: <20190507185816.GC17205@kroah.com> References: <20190507121952.495564307@linutronix.de> <20190507141746.GA28384@kroah.com> <20190507181435.GB13061@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Tue, May 07, 2019 at 08:43:44PM +0200, Thomas Gleixner wrote: > On Tue, 7 May 2019, Greg KH wrote: > > On Tue, May 07, 2019 at 04:19:35PM +0200, Thomas Gleixner wrote: > > > On Tue, 7 May 2019, Greg KH wrote: > > > > On Tue, May 07, 2019 at 02:19:52PM +0200, Thomas Gleixner wrote: > > > > > Hi! > > > > > > > > > > As promised here are the first 4 automatically generated patches. Each > > > > > patch handles exactly one match pattern (rule). > > > > > > > > > > While reviewing the patch (actual code change) might be massively time > > > > > consuming, the quick and important part is to look at the patterns and > > > > > verify whether the license conclusion is correct. The tooling which > > > > > replaces exactly those patterns is pretty solid by now. But if you really > > > > > insists on looking at each individual file change, you're welcome. :) > > > > > > > > > > Note that some of the patterns contain obscure things like: > > > > > > > > > > [no]_[pad]_[ctrl] > > > > > > > > > > in the middle. This one is a clear copy and paste artifact which happens to > > > > > be in arch/arm/mach-imx/iomux-mx35.h: > > > > > > > > > > * of the License, or (at your option, NO_PAD_CTRL) any later version. > > > > > > > > > > Oh well..... > > > > > > > > What's the diffstat of all 4 of these patches? How many files are you > > > > fixing up here? > > > > > > Oops. Forgot to add that. > > > > > > 305 files changed, 311 insertions(+), 2789 deletions(-) > > > > Nice, but I would have expected more files to be touched here :) > > It's 4 out of 514 patches on the step2 branch. > > step1-3 result with all patches applied in: > > 24524 files changed, 24721 insertions(+), 184320 deletions(-) That's better :) > > Anyway, these all look good to me. I'm guessing the subject lines will > > be tweaked. If there's anything I can do to run the script and send out > > patches, please let me know. > > You have a big enough machine? I think I do: $ free -h total used free shared buff/cache available Mem: 118Gi 994Mi 113Gi 1.0Mi 3.3Gi 115Gi Swap: 4.0Gi 0B 4.0Gi It's what I do my stable kernel build testing on :) Anyway, glad to help out if you want me to. greg k-h