From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9806EC28CC0 for ; Fri, 31 May 2019 01:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B32F26167 for ; Fri, 31 May 2019 01:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559265476; bh=M+lPoN+MoPWIsJVjNM57ecTvSflunf2Z2+s0qDAH5zM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RqHW9EKKe7chc/LLEYr9WZizPkiqY1SkEJu7B60gYUlJNKY1ObSK7QBtqTS3jIoYv drzowG+2CxfqpWG/auDwdcbGC8yOTA4FuKBJ092Vaqz8/zBbpzIhYmgR34APLuWQhQ Rv0miz2yW8H1QEsl5+oTtl/G8qcWrdIMN6y3CBSQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbfEaBR4 (ORCPT ); Thu, 30 May 2019 21:17:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:37804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbfEaBR4 (ORCPT ); Thu, 30 May 2019 21:17:56 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03ADF26142; Fri, 31 May 2019 01:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559265475; bh=M+lPoN+MoPWIsJVjNM57ecTvSflunf2Z2+s0qDAH5zM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ss0i6/RAYnH6Olq5csMvkLWLgiCxsV8l3/pKIwVHnwb5xiwAA6X7R5TDWoS7bKZGC iWUXZMgY+9n3GDyA4fpRnUSdTV+tQwb9unL3PVwzeeuQSuey9vxn7inx06fVjJp/83 RAfJjIPPtrjun/BIg9/Pzvwwv/cUErLA3ABsi7Uk= Date: Thu, 30 May 2019 18:17:54 -0700 From: Greg KH To: Masahiro Yamada Cc: Kate Stewart , Thomas Gleixner , linux-spdx@vger.kernel.org Subject: Re: Missing SPDX tags for Kbuild files Message-ID: <20190531011754.GA26521@kroah.com> References: <20190530115256.GA30967@kroah.com> <20190530183146.GA31985@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Fri, May 31, 2019 at 09:40:26AM +0900, Masahiro Yamada wrote: > On Fri, May 31, 2019 at 3:31 AM Greg KH wrote: > > > > On Thu, May 30, 2019 at 07:01:01AM -0500, Kate Stewart wrote: > > > On Thu, May 30, 2019 at 6:53 AM Greg KH wrote: > > > > > > > > On Thu, May 30, 2019 at 05:58:05PM +0900, Masahiro Yamada wrote: > > > > > Hi. > > > > > > > > > > > > > > > Recently, "Makefiles", "Kconfig" files were given with SPDX License tags. > > > > > > > > > > Author: Thomas Gleixner > > > > > Date: Sun May 19 13:07:45 2019 +0100 > > > > > > > > > > treewide: Add SPDX license identifier - Makefile/Kconfig > > > > > > > > > > > > > > > > > > > > > > > > > But, the file name "Kbuild" is also a Makefile. > > > > > > > > > > Conventionally, Linux build system uses both "Kbuild" and "Makefile". > > > > > > > > > > > > > > > For example, SPDX tag is missing in > > > > > > > > > > arch/x86/Kbuild > > > > > arch/x86/include/uapi/asm/Kbuild > > > > > arch/x86/include/asm/Kbuild > > > > > > > > > > > > > > > Will somebody work on "Kbuild" files please ? > > > > > > > > Sure, how about the attached patch, any objection to me queueing it up? > > > > > > Thanks Greg. > > > > > > Thomas' initial patch fixed a bunch of these in the initial cleanup, > > > but I guess > > > more were added (and overlooked since then). > > > > > > Reviewed-by: Kate Stewart > > > > Thanks for the review, I'll queue this up with the next round of patches > > from Thomas to go to Linus. > > Thanks. > > > > Bikeshed: > > Commit ec8f24b7faaf3d4799a7c3f4c1b87f6b02778ad1 > used "GPL-2.0-only". > > So, I prefer avoiding the deprecated "GPL-2.0". I know, but I like that version better, the whole "-only" thing I consider crazy and nonsense :) > We have been discussing here: > https://lkml.org/lkml/2019/5/30/1575 Both versions are just fine to use in the kernel at this point in time. As this only touches 100 or so files, it's not a big deal, we have much bigger issues to worry about here. thnaks, greg k-h