From: Greg KH <greg@kroah.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-spdx@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Joe Perches <joe@perches.com>, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
linux-gpio@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-renesas-soc@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] treewide: fix typos of SPDX-License-Identifier
Date: Sat, 1 Jun 2019 18:29:45 +0200 [thread overview]
Message-ID: <20190601162945.GA6395@kroah.com> (raw)
In-Reply-To: <20190601032242.10405-1-yamada.masahiro@socionext.com>
On Sat, Jun 01, 2019 at 12:22:42PM +0900, Masahiro Yamada wrote:
> Prior to the adoption of SPDX, it was difficult for tools to determine
> the correct license due to incomplete or badly formatted license text.
> The SPDX solves this issue, assuming people can correctly spell
> "SPDX-License-Identifier" although this assumption is broken in some
> places.
>
> Since scripts/spdxcheck.py parses only lines that exactly matches to
> the correct tag, it cannot (should not) detect this kind of error.
>
> If the correct tag is missing, scripts/checkpatch.pl warns like this:
>
> WARNING: Missing or malformed SPDX-License-Identifier tag in line *
>
> So, people should notice it before the patch submission, but in reality
> broken tags sometimes slip in. The checkpatch warning is not useful for
> checking the committed files globally since large number of files still
> have no SPDX tag.
>
> Also, I am not sure about the legal effect when the SPDX tag is broken.
>
> Anyway, these typos are absolutely worth fixing. It is pretty easy to
> find suspicious lines by grep.
>
> $ git grep --not -e SPDX-License-Identifier --and -e SPDX- -- \
> :^LICENSES :^scripts/spdxcheck.py :^*/license-rules.rst
> arch/arm/kernel/bugs.c:// SPDX-Identifier: GPL-2.0
> drivers/phy/st/phy-stm32-usbphyc.c:// SPDX-Licence-Identifier: GPL-2.0
> drivers/pinctrl/sh-pfc/pfc-r8a77980.c:// SPDX-Lincense-Identifier: GPL 2.0
> lib/test_stackinit.c:// SPDX-Licenses: GPLv2
> sound/soc/codecs/max9759.c:// SPDX-Licence-Identifier: GPL-2.0
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Very nice catch, thanks! I'll go queue this up now.
greg k-h
next prev parent reply other threads:[~2019-06-01 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 3:22 [PATCH] treewide: fix typos of SPDX-License-Identifier Masahiro Yamada
2019-06-01 16:29 ` Greg KH [this message]
2019-06-03 7:07 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601162945.GA6395@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kishon@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).