Linux-SPDX Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3] gpu/drm_memory: fix a few warnings
@ 2019-07-09 15:13 Qian Cai
  2019-07-12 19:45 ` Qian Cai
  0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2019-07-09 15:13 UTC (permalink / raw)
  To: akpm
  Cc: imirkin, airlied, daniel, maarten.lankhorst, sean, joe, rfontana,
	tglx, torvalds, corbet, gregkh, linux-spdx, dri-devel,
	linux-kernel, Qian Cai

The opening comment mark "/**" is reserved for kernel-doc comments, so
it will generate a warning with "make W=1".

drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand  * \file
drm_memory.c

Also, silence a checkpatch warning by adding a license identfiter where
it indicates the MIT license further down in the source file.

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Fix it by adding the MIT SPDX identifier without touching the boilerplate
language.

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Qian Cai <cai@lca.pw>
---

v3: Keep the boilerplate language.
v2: Remove the redundant description of the license.

 drivers/gpu/drm/drm_memory.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
index 132fef8ff1b6..683042c8ee2c 100644
--- a/drivers/gpu/drm/drm_memory.c
+++ b/drivers/gpu/drm/drm_memory.c
@@ -1,4 +1,5 @@
-/**
+// SPDX-License-Identifier: MIT
+/*
  * \file drm_memory.c
  * Memory management wrappers for DRM
  *
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] gpu/drm_memory: fix a few warnings
  2019-07-09 15:13 [PATCH v3] gpu/drm_memory: fix a few warnings Qian Cai
@ 2019-07-12 19:45 ` Qian Cai
  2019-07-15 11:02   ` Emil Velikov
  0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2019-07-12 19:45 UTC (permalink / raw)
  To: akpm
  Cc: imirkin, airlied, daniel, maarten.lankhorst, sean, joe, rfontana,
	tglx, torvalds, corbet, gregkh, linux-spdx, dri-devel,
	linux-kernel

Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit
about SPDX can pick this up. It occurs to me none of DRM maintainers cares about
this as there is no feedback from any of them for months since v1.

On Tue, 2019-07-09 at 11:13 -0400, Qian Cai wrote:
> The opening comment mark "/**" is reserved for kernel-doc comments, so
> it will generate a warning with "make W=1".
> 
> drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand  * \file
> drm_memory.c
> 
> Also, silence a checkpatch warning by adding a license identfiter where
> it indicates the MIT license further down in the source file.
> 
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Fix it by adding the MIT SPDX identifier without touching the boilerplate
> language.
> 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> 
> v3: Keep the boilerplate language.
> v2: Remove the redundant description of the license.
> 
>  drivers/gpu/drm/drm_memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> index 132fef8ff1b6..683042c8ee2c 100644
> --- a/drivers/gpu/drm/drm_memory.c
> +++ b/drivers/gpu/drm/drm_memory.c
> @@ -1,4 +1,5 @@
> -/**
> +// SPDX-License-Identifier: MIT
> +/*
>   * \file drm_memory.c
>   * Memory management wrappers for DRM
>   *

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] gpu/drm_memory: fix a few warnings
  2019-07-12 19:45 ` Qian Cai
@ 2019-07-15 11:02   ` Emil Velikov
  0 siblings, 0 replies; 3+ messages in thread
From: Emil Velikov @ 2019-07-15 11:02 UTC (permalink / raw)
  To: Qian Cai
  Cc: akpm, corbet, airlied, torvalds, linux-kernel, dri-devel,
	rfontana, gregkh, joe, linux-spdx, tglx, sean

Hi Qian,

On 2019/07/12, Qian Cai wrote:
> Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit
> about SPDX can pick this up. It occurs to me none of DRM maintainers cares about
> this as there is no feedback from any of them for months since v1.
> 
AFAICT there are a couple of reasons why this has gone unnoticed:
 - summary is the pretty ambiguous
 - commit does two thigs

Another thing to consider is that this patch touches a single file,
while the exact same issue is also present in many other files.

Quick look at the following lists:
head -n2 drivers/gpu/drm/drm_*[ch]  | less

drm_agpsupport.c
drm_dma.c
drm_legacy_misc.c
drm_lock.c
drm_memory.c
drm_scatter.c
drm_vm.c

If you can fixup the s|/**|/*| in the above, I'd gladly merge the patch.

On the topic of SPDX - no objection on my end, but it should be a
separate patch, which replaces the explicit verbose license text with
the tag.

Thanks
Emil

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 15:13 [PATCH v3] gpu/drm_memory: fix a few warnings Qian Cai
2019-07-12 19:45 ` Qian Cai
2019-07-15 11:02   ` Emil Velikov

Linux-SPDX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spdx/0 linux-spdx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spdx linux-spdx/ https://lore.kernel.org/linux-spdx \
		linux-spdx@vger.kernel.org linux-spdx@archiver.kernel.org
	public-inbox-index linux-spdx


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spdx


AGPL code for this site: git clone https://public-inbox.org/ public-inbox