Linux-SPDX Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
       [not found] ` <20190622145516.3231-14-jic23@kernel.org>
@ 2019-07-17 17:58   ` Himanshu Jha
  2019-07-17 21:12     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Himanshu Jha @ 2019-07-17 17:58 UTC (permalink / raw)
  To: jic23
  Cc: linux-iio, Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron, linux-spdx

On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Not exactly standard license text, but clear in intent and it's
> my copyright anyway.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/iio/trigger/iio-trig-loop.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> index 9258d3cf149b..f0205a9e47d0 100644
> --- a/drivers/iio/trigger/iio-trig-loop.c
> +++ b/drivers/iio/trigger/iio-trig-loop.c
> @@ -1,8 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0

I think it should be:

	// SPDX-License-Identifier: GPL-2.0-only

https://spdx.org/licenses/
https://spdx.org/licenses/GPL-2.0-only.html

I don't know if `spdxcheck.py` points out about
such a mismatch.

Yes, documentation and sanity checkers needs to be updated.
https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/


>  /*
>   * Copyright 2016 Jonathan Cameron <jic23@kernel.org>
>   *
> - * Licensed under the GPL-2.
> - *
>   * Based on a mashup of the hrtimer trigger and continuous sampling proposal of
>   * Gregor Boirie <gregor.boirie@parrot.com>
>   *
> -- 
> 2.22.0
> 

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-07-17 17:58   ` [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2 Himanshu Jha
@ 2019-07-17 21:12     ` Greg KH
  2019-08-17 19:08       ` J Lovejoy
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-07-17 21:12 UTC (permalink / raw)
  To: Himanshu Jha
  Cc: jic23, linux-iio, Daniel Baluta, Lars-Peter Clausen,
	Hartmut Knaack, Peter Meerwald-Stadler, Jonathan Cameron,
	linux-spdx

On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote:
> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Not exactly standard license text, but clear in intent and it's
> > my copyright anyway.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> >  drivers/iio/trigger/iio-trig-loop.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> > index 9258d3cf149b..f0205a9e47d0 100644
> > --- a/drivers/iio/trigger/iio-trig-loop.c
> > +++ b/drivers/iio/trigger/iio-trig-loop.c
> > @@ -1,8 +1,7 @@
> > +// SPDX-License-Identifier: GPL-2.0
> 
> I think it should be:
> 
> 	// SPDX-License-Identifier: GPL-2.0-only
> 
> https://spdx.org/licenses/
> https://spdx.org/licenses/GPL-2.0-only.html
> 
> I don't know if `spdxcheck.py` points out about
> such a mismatch.
> 
> Yes, documentation and sanity checkers needs to be updated.
> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/

Please read the in-kernel documentation about this.  We support both
types of tags now and have done so since the beginning.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-07-17 21:12     ` Greg KH
@ 2019-08-17 19:08       ` J Lovejoy
  2019-08-17 20:38         ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: J Lovejoy @ 2019-08-17 19:08 UTC (permalink / raw)
  To: Greg KH
  Cc: Himanshu Jha, jic23, linux-iio, Daniel Baluta,
	Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald-Stadler,
	Jonathan Cameron, linux-spdx



> On Jul 17, 2019, at 3:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote:
>> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
>>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> 
>>> Not exactly standard license text, but clear in intent and it's
>>> my copyright anyway.
>>> 
>>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> ---
>>> drivers/iio/trigger/iio-trig-loop.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>> 
>>> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
>>> index 9258d3cf149b..f0205a9e47d0 100644
>>> --- a/drivers/iio/trigger/iio-trig-loop.c
>>> +++ b/drivers/iio/trigger/iio-trig-loop.c
>>> @@ -1,8 +1,7 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>> 
>> I think it should be:
>> 
>> 	// SPDX-License-Identifier: GPL-2.0-only
>> 
>> https://spdx.org/licenses/
>> https://spdx.org/licenses/GPL-2.0-only.html
>> 
>> I don't know if `spdxcheck.py` points out about
>> such a mismatch.
>> 
>> Yes, documentation and sanity checkers needs to be updated.
>> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/
> 
> Please read the in-kernel documentation about this.  We support both
> types of tags now and have done so since the beginning.
> 
> 
While I understand that the previous SPDX License List and current version identifiers are supported here, it would be really helpful more generally if we could use the current ones now and going forward.

Thanks,
Jilayne
SPDX legal team co-lead


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-08-17 19:08       ` J Lovejoy
@ 2019-08-17 20:38         ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-08-17 20:38 UTC (permalink / raw)
  To: J Lovejoy
  Cc: Himanshu Jha, jic23, linux-iio, Daniel Baluta,
	Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald-Stadler,
	Jonathan Cameron, linux-spdx

On Sat, Aug 17, 2019 at 01:08:44PM -0600, J Lovejoy wrote:
> 
> 
> > On Jul 17, 2019, at 3:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote:
> >> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
> >>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >>> 
> >>> Not exactly standard license text, but clear in intent and it's
> >>> my copyright anyway.
> >>> 
> >>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >>> ---
> >>> drivers/iio/trigger/iio-trig-loop.c | 3 +--
> >>> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>> 
> >>> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> >>> index 9258d3cf149b..f0205a9e47d0 100644
> >>> --- a/drivers/iio/trigger/iio-trig-loop.c
> >>> +++ b/drivers/iio/trigger/iio-trig-loop.c
> >>> @@ -1,8 +1,7 @@
> >>> +// SPDX-License-Identifier: GPL-2.0
> >> 
> >> I think it should be:
> >> 
> >> 	// SPDX-License-Identifier: GPL-2.0-only
> >> 
> >> https://spdx.org/licenses/
> >> https://spdx.org/licenses/GPL-2.0-only.html
> >> 
> >> I don't know if `spdxcheck.py` points out about
> >> such a mismatch.
> >> 
> >> Yes, documentation and sanity checkers needs to be updated.
> >> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/
> > 
> > Please read the in-kernel documentation about this.  We support both
> > types of tags now and have done so since the beginning.
> > 
> > 
> While I understand that the previous SPDX License List and current
> version identifiers are supported here, it would be really helpful
> more generally if we could use the current ones now and going forward.

That is fine, but for now, both are acceptable, it's up to the submitter
to pick which they want to use, we have much bigger things to worry
about here :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190622145516.3231-1-jic23@kernel.org>
     [not found] ` <20190622145516.3231-14-jic23@kernel.org>
2019-07-17 17:58   ` [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2 Himanshu Jha
2019-07-17 21:12     ` Greg KH
2019-08-17 19:08       ` J Lovejoy
2019-08-17 20:38         ` Greg KH

Linux-SPDX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spdx/0 linux-spdx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spdx linux-spdx/ https://lore.kernel.org/linux-spdx \
		linux-spdx@vger.kernel.org linux-spdx@archiver.kernel.org
	public-inbox-index linux-spdx


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spdx


AGPL code for this site: git clone https://public-inbox.org/ public-inbox