linux-spdx.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Douglas Gilbert <dgilbert@interlog.com>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
	jejb@linux.vnet.ibm.com, hare@suse.de, bvanassche@acm.org,
	linux-spdx@vger.kernel.org
Subject: Re: [PATCH v3 07/20] sg: move header to uapi section
Date: Mon, 12 Aug 2019 07:24:51 -0700	[thread overview]
Message-ID: <20190812142451.GG8105@infradead.org> (raw)
In-Reply-To: <20190807114252.2565-8-dgilbert@interlog.com>

[note: question for the linux-spdx audience below]

> -
>  #ifdef __KERNEL__
>  extern int sg_big_buff; /* for sysctl */
>  #endif

FYI, these __KERNEL__ ifdefs in non-uapi headers should go away.

>  
> +/*
> + * In version 3.9.01 of the sg driver, this file was spilt in two, with the
> + * bulk of the user space interface being placed in the file being included
> + * in the following line.
> + */
> +#include <uapi/scsi/sg.h>

Splitting uapi headers is standard practive, no need for the comment,
especially not with a meaningless driver version number.

> diff --git a/include/uapi/scsi/sg.h b/include/uapi/scsi/sg.h
> new file mode 100644
> index 000000000000..072b45bd732f
> --- /dev/null
> +++ b/include/uapi/scsi/sg.h
> @@ -0,0 +1,329 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

This needs the syscall noticed for uapi headers.  FYI, what is our
stance of just adding that notice to headers newly moved to UAPI?
Do we need agreement from everyone who touched the file?  Or just
after we started the split and SPDX annotations, as in this case
this header used to be available to user programs?

       reply	other threads:[~2019-08-12 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190807114252.2565-1-dgilbert@interlog.com>
     [not found] ` <20190807114252.2565-8-dgilbert@interlog.com>
2019-08-12 14:24   ` Christoph Hellwig [this message]
2019-08-12 14:32     ` [PATCH v3 07/20] sg: move header to uapi section Greg KH
2019-08-12 14:35     ` James Bottomley
2019-08-13  0:21     ` Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190812142451.GG8105@infradead.org \
    --to=hch@infradead.org \
    --cc=bvanassche@acm.org \
    --cc=dgilbert@interlog.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-spdx@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).