Linux-SPDX Archive on lore.kernel.org
 help / color / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: J Lovejoy <opensource@jilayne.com>
Cc: Himanshu Jha <himanshujha199640@gmail.com>,
	jic23@kernel.org, linux-iio@vger.kernel.org,
	Daniel Baluta <daniel.baluta@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-spdx@vger.kernel.org
Subject: Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
Date: Sat, 17 Aug 2019 22:38:55 +0200
Message-ID: <20190817203855.GA8340@kroah.com> (raw)
In-Reply-To: <EB9A92CE-36F5-4A27-8984-655538DEF40B@jilayne.com>

On Sat, Aug 17, 2019 at 01:08:44PM -0600, J Lovejoy wrote:
> 
> 
> > On Jul 17, 2019, at 3:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote:
> >> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
> >>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >>> 
> >>> Not exactly standard license text, but clear in intent and it's
> >>> my copyright anyway.
> >>> 
> >>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >>> ---
> >>> drivers/iio/trigger/iio-trig-loop.c | 3 +--
> >>> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>> 
> >>> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> >>> index 9258d3cf149b..f0205a9e47d0 100644
> >>> --- a/drivers/iio/trigger/iio-trig-loop.c
> >>> +++ b/drivers/iio/trigger/iio-trig-loop.c
> >>> @@ -1,8 +1,7 @@
> >>> +// SPDX-License-Identifier: GPL-2.0
> >> 
> >> I think it should be:
> >> 
> >> 	// SPDX-License-Identifier: GPL-2.0-only
> >> 
> >> https://spdx.org/licenses/
> >> https://spdx.org/licenses/GPL-2.0-only.html
> >> 
> >> I don't know if `spdxcheck.py` points out about
> >> such a mismatch.
> >> 
> >> Yes, documentation and sanity checkers needs to be updated.
> >> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/
> > 
> > Please read the in-kernel documentation about this.  We support both
> > types of tags now and have done so since the beginning.
> > 
> > 
> While I understand that the previous SPDX License List and current
> version identifiers are supported here, it would be really helpful
> more generally if we could use the current ones now and going forward.

That is fine, but for now, both are acceptable, it's up to the submitter
to pick which they want to use, we have much bigger things to worry
about here :)

thanks,

greg k-h

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190622145516.3231-1-jic23@kernel.org>
     [not found] ` <20190622145516.3231-14-jic23@kernel.org>
2019-07-17 17:58   ` Himanshu Jha
2019-07-17 21:12     ` Greg KH
2019-08-17 19:08       ` J Lovejoy
2019-08-17 20:38         ` Greg KH [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190817203855.GA8340@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=daniel.baluta@gmail.com \
    --cc=himanshujha199640@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-spdx@vger.kernel.org \
    --cc=opensource@jilayne.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPDX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spdx/0 linux-spdx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spdx linux-spdx/ https://lore.kernel.org/linux-spdx \
		linux-spdx@vger.kernel.org
	public-inbox-index linux-spdx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spdx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git