archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <>
To: Greg Kroah-Hartman <>,
	Thomas Gleixner <>
Cc: <>, <>,
	Rahul T R <>, Nishanth Menon <>
Subject: [PATCH] scripts/ Lets strictly read license files in utf-8
Date: Fri, 2 Jul 2021 20:21:28 -0500	[thread overview]
Message-ID: <> (raw)

Commit bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")
unfortunately introduced LICENSES/dual/CC-BY-4.0 in UTF-8 Unicode text
While python will barf at it with:

FAIL: 'ascii' codec can't decode byte 0xe2 in position 2109: ordinal not in range(128)
Traceback (most recent call last):
  File "scripts/", line 244, in <module>
    spdx = read_spdxdata(repo)
  File "scripts/", line 47, in read_spdxdata
    for l in open(el.path).readlines():
  File "/usr/lib/python3.6/encodings/", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 2109: ordinal not in range(128)

While it is indeed debatable if 'Licensor.' used in the license file
needs unicode quotes, instead, let us force spdxcheck to read utf-8

Reported-by: Rahul T R <>
Signed-off-by: Nishanth Menon <>
 scripts/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/ b/scripts/
index 3e784cf9f401..ebd06ae642c9 100755
--- a/scripts/
+++ b/scripts/
@@ -44,7 +44,7 @@ def read_spdxdata(repo):
             exception = None
-            for l in open(el.path).readlines():
+            for l in open(el.path, encoding="utf-8").readlines():
                 if l.startswith('Valid-License-Identifier:'):
                     lid = l.split(':')[1].strip().upper()
                     if lid in spdx.licenses:

             reply	other threads:[~2021-07-03  1:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-03  1:21 Nishanth Menon [this message]
2021-07-07  9:00 ` Thomas Gleixner
2021-07-07 16:53   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] scripts/ Lets strictly read license files in utf-8' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).