linux-spdx.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allison Randal <allison@lohutok.net>
To: Thomas Gleixner <tglx@linutronix.de>, linux-spdx@vger.kernel.org
Subject: Re: [ASIS-1 patch 0/6] Deep review of 'AS IS' disclaimers - part 1
Date: Sat, 8 Jun 2019 15:05:26 -0400	[thread overview]
Message-ID: <6e615331-9b3d-612b-5802-610b207d3d41@lohutok.net> (raw)
In-Reply-To: <20190605101543.586282830@linutronix.de>

On 6/5/19 6:15 AM, Thomas Gleixner wrote:
> 
> The first batch is from the 'AS IS' category. All patches in this series
> have the same modification of the standard GPLv2 disclaimer.
> 
> Standard disclaimer:
> 
>     this program is distributed in the hope that it will be useful
>     but without any warranty without even the implied warranty of
>     merchantability or fitness for a particular purpose
> 
> Modified diclaimer:
> 
>     this program is distributed as is without any warranty of any kind
>     whether express[ed] or implied without even the implied warranty of
>     merchantability or fitness for a particular purpose
> 
> The NO WARRANTY section of the GPLv2 contains:
> 
>     PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER
>     EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>     WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> 
> In my opinion the modified disclaimer contains nothing which is
> substantially different, but I might be wrong as usual.

I agree, they seem to have simply copied disclaimer language from the
GPLv2 and added it to the disclaimer notice. So they aren't adding any
disclaimers beyond what would have applied to the file anyway, and the
SPDX identifier is equivalent to the existing notice.

I'll go ahead and review the patches in this set positively, but I
suggest waiting for at least one lawyer to review before moving ahead
with these patches.

> In case we agree on that, I would amend the changelogs of the individual
> patches with a paragraph explaining our conclusion. Something along the
> lines:
> 
>     The patterns deviate from the standard GPLv2 disclaimer, but the
>     modification does not expand beyond the standard disclaimer and the NO
>     WARRANTY section of the GPLv2. So replacing the license notice
>     including the modified disclaimer with the SPDX license identifier
>     results in the same protections and conditions.
> 
> Feel free to suggest better wording or deeper explanation.

Seems fine to me. Maybe add the word "notice" to the end of the first
sentence? It just seems a little confusing that the paragraph has the
word "disclaimer" referring to both the file notice and the license
itself. Someone else may have a better idea how to clarify.

Allison

      parent reply	other threads:[~2019-06-08 19:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 10:15 Thomas Gleixner
2019-06-05 10:15 ` [ASIS-1 patch 1/6] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 124 Thomas Gleixner
2019-06-08 19:06   ` Allison Randal
2019-06-05 10:15 ` [ASIS-1 patch 2/6] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 304 Thomas Gleixner
2019-06-08 19:07   ` Allison Randal
2019-06-05 10:15 ` [ASIS-1 patch 3/6] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 317 Thomas Gleixner
2019-06-08 19:07   ` Allison Randal
2019-06-05 10:15 ` [ASIS-1 patch 4/6] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 318 Thomas Gleixner
2019-06-08 19:08   ` Allison Randal
2019-06-05 10:15 ` [ASIS-1 patch 5/6] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 319 Thomas Gleixner
2019-06-08 19:09   ` Allison Randal
2019-06-05 10:15 ` [ASIS-1 patch 6/6] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 413 Thomas Gleixner
2019-06-08 19:10   ` Allison Randal
2019-06-05 16:04 ` [ASIS-1 patch 0/6] Deep review of 'AS IS' disclaimers - part 1 Enrico Weigelt, metux IT consult
2019-06-08 19:05 ` Allison Randal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e615331-9b3d-612b-5802-610b207d3d41@lohutok.net \
    --to=allison@lohutok.net \
    --cc=linux-spdx@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [ASIS-1 patch 0/6] Deep review of '\''AS IS'\'' disclaimers - part 1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox