Linux-SPDX Archive on lore.kernel.org
 help / color / Atom feed
From: Allison Randal <allison@lohutok.net>
To: Thomas Gleixner <tglx@linutronix.de>, J Lovejoy <opensource@jilayne.com>
Cc: linux-spdx@vger.kernel.org
Subject: Re: [patch 02/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 2
Date: Mon, 20 May 2019 14:14:44 -0700
Message-ID: <745cf776-8af8-e09f-7457-cbcb523fbe03@lohutok.net> (raw)
In-Reply-To: <alpine.DEB.2.21.1905201938190.1635@nanos.tec.linutronix.de>

On 5/20/19 6:47 PM, Thomas Gleixner wrote:
> 
> We really need to spot the failures in the patterns, not the actual file
> level patches. The patcher itself is going to remove the file level
> equivalent of the normalized pattern and add the concluded SPDX identifier
> instead. Not more, not less.

I'll back that up: the word *library* was in the pattern, and that's the
only reason it matched that file. So, in our reviews, we need to
carefully check that the pattern correctly corresponds to the SPDX
identifier. But, the pattern matches are very literal/exact, so we don't
need to be worried about some random files that don't exactly match the
pattern sneaking into the patch, or review every file in the patch.

(I do review a few files, but it's just for the mental reassurance that
I've read the pattern correctly.)

> If the tools would be perfect we would not need to look at any of these
> things ...

Fuzzy text matching is hard. This is why we have SPDX. :) Our efforts
here will make a million future license compliance scans of the Kernel
cleaner and more accurate.

Allison

  parent reply index

Thread overview: 148+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 13:51 [patch 00/25] First batch Thomas Gleixner
2019-05-19 13:51 ` [patch 01/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1 Thomas Gleixner
2019-05-19 17:23   ` J Lovejoy
2019-05-19 17:28     ` Kate Stewart
2019-05-19 21:47       ` Allison Randal
2019-05-20  1:03   ` Steve Winslow
2019-05-20  9:00   ` Greg KH
2019-05-20  9:04     ` Thomas Gleixner
2019-05-20  9:22       ` Greg KH
2019-05-20 20:13         ` Thomas Gleixner
2019-05-21 14:18   ` Michael Ellerman
2019-05-19 13:51 ` [patch 02/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 2 Thomas Gleixner
2019-05-19 17:29   ` Kate Stewart
2019-05-19 21:50   ` Allison Randal
2019-05-20  0:44     ` Steve Winslow
2019-05-20  4:00     ` Thomas Gleixner
2019-05-20 17:17       ` J Lovejoy
2019-05-20 17:47         ` Thomas Gleixner
2019-05-20 18:09           ` Thomas Gleixner
2019-05-20 21:14           ` Allison Randal [this message]
2019-05-20 22:07     ` Philippe Ombredanne
2019-05-20 22:34       ` Allison Randal
2019-05-19 13:51 ` [patch 03/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 3 Thomas Gleixner
2019-05-19 17:24   ` J Lovejoy
2019-05-19 17:30     ` Kate Stewart
2019-05-19 21:51       ` Allison Randal
2019-05-20  1:04   ` Steve Winslow
2019-05-19 13:51 ` [patch 04/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 4 Thomas Gleixner
2019-05-19 17:25   ` J Lovejoy
2019-05-19 21:53     ` Allison Randal
2019-05-20  1:05   ` Steve Winslow
2019-05-19 13:51 ` [patch 05/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 5 Thomas Gleixner
2019-05-19 17:25   ` J Lovejoy
2019-05-19 21:54     ` Allison Randal
2019-05-20  1:05   ` Steve Winslow
2019-05-21  1:20   ` Kate Stewart
2019-05-19 13:51 ` [patch 06/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 6 Thomas Gleixner
2019-05-19 17:28   ` J Lovejoy
2019-05-19 22:32     ` Allison Randal
2019-05-20  0:53   ` Steve Winslow
2019-05-20 11:10     ` Thomas Gleixner
2019-05-20 16:50       ` Philippe Ombredanne
2019-05-19 13:51 ` [patch 07/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 7 Thomas Gleixner
2019-05-19 17:29   ` J Lovejoy
2019-05-19 22:35     ` Allison Randal
2019-05-20  1:06   ` Steve Winslow
2019-05-21  1:21   ` Kate Stewart
2019-05-19 13:51 ` [patch 08/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 8 Thomas Gleixner
2019-05-19 17:30   ` J Lovejoy
2019-05-19 22:40     ` Allison Randal
2019-05-20  0:57   ` Steve Winslow
2019-05-20  8:51     ` Thomas Gleixner
2019-05-19 13:51 ` [patch 09/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 9 Thomas Gleixner
2019-05-19 17:30   ` J Lovejoy
2019-05-19 23:17     ` Allison Randal
2019-05-20  1:06   ` Steve Winslow
2019-05-21  1:21   ` Kate Stewart
2019-05-19 13:51 ` [patch 10/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 10 Thomas Gleixner
2019-05-19 17:31   ` J Lovejoy
2019-05-19 23:18     ` Allison Randal
2019-05-20  1:06   ` Steve Winslow
2019-05-21  1:22   ` Kate Stewart
2019-05-19 13:51 ` [patch 11/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 11 Thomas Gleixner
2019-05-19 17:31   ` J Lovejoy
2019-05-19 23:19     ` Allison Randal
2019-05-20  1:07   ` Steve Winslow
2019-05-21  1:22   ` Kate Stewart
2019-05-19 13:51 ` [patch 12/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 12 Thomas Gleixner
2019-05-19 17:36   ` J Lovejoy
2019-05-19 23:26     ` Allison Randal
2019-05-20  1:07   ` Steve Winslow
2019-05-21  1:23   ` Kate Stewart
2019-05-19 13:51 ` [patch 13/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13 Thomas Gleixner
2019-05-19 17:38   ` J Lovejoy
2019-05-19 23:27     ` Allison Randal
2019-05-20  1:08   ` Steve Winslow
2019-05-21  1:24   ` Kate Stewart
2019-05-21 14:20   ` Michael Ellerman
2019-05-19 13:51 ` [patch 14/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 14 Thomas Gleixner
     [not found]   ` <01BD65EE-6C09-45E4-ACAB-074B16C19EE5@jilayne.com>
2019-05-19 17:49     ` J Lovejoy
2019-05-19 23:30       ` Allison Randal
2019-05-20  1:08   ` Steve Winslow
2019-05-21  1:26   ` Kate Stewart
2019-05-19 13:51 ` [patch 15/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 15 Thomas Gleixner
     [not found]   ` <345D7893-767F-42C5-A73D-599338174AAA@jilayne.com>
2019-05-19 17:50     ` J Lovejoy
2019-05-19 23:40       ` Allison Randal
2019-05-20  1:09   ` Steve Winslow
2019-05-21  1:26   ` Kate Stewart
2019-05-19 13:51 ` [patch 16/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 16 Thomas Gleixner
2019-05-19 17:41   ` J Lovejoy
2019-05-19 23:40     ` Allison Randal
2019-05-20  0:27   ` Steve Winslow
2019-05-20  0:42     ` Richard Fontana
2019-05-20  2:42       ` Allison Randal
2019-05-20  5:25         ` Thomas Gleixner
2019-05-20 16:38       ` Philippe Ombredanne
2019-05-20 17:10         ` Richard Fontana
2019-05-20 17:28           ` Thomas Gleixner
2019-05-20 22:43             ` Philippe Ombredanne
2019-05-20  8:31   ` Thomas Gleixner
2019-05-19 13:51 ` [patch 17/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 17 Thomas Gleixner
2019-05-19 17:41   ` J Lovejoy
2019-05-19 23:41     ` Allison Randal
2019-05-20  1:10   ` Steve Winslow
2019-05-21  1:28   ` Kate Stewart
2019-05-19 13:51 ` [patch 18/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18 Thomas Gleixner
2019-05-19 17:42   ` J Lovejoy
2019-05-19 23:49     ` Allison Randal
2019-05-20  1:10   ` Steve Winslow
2019-05-21  1:28   ` Kate Stewart
2019-05-19 13:51 ` [patch 19/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 19 Thomas Gleixner
2019-05-19 17:50   ` J Lovejoy
2019-05-19 23:50     ` Allison Randal
2019-05-20  1:11   ` Steve Winslow
2019-05-21  1:29   ` Kate Stewart
2019-05-19 13:51 ` [patch 20/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 20 Thomas Gleixner
2019-05-19 17:43   ` J Lovejoy
2019-05-19 23:57     ` Allison Randal
2019-05-20  1:11   ` Steve Winslow
2019-05-21  1:30   ` Kate Stewart
2019-05-19 13:51 ` [patch 21/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 21 Thomas Gleixner
2019-05-19 17:44   ` J Lovejoy
2019-05-19 23:58     ` Allison Randal
2019-05-20  1:11   ` Steve Winslow
2019-05-21  1:31   ` Kate Stewart
2019-05-19 13:51 ` [patch 22/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 22 Thomas Gleixner
2019-05-19 17:45   ` J Lovejoy
2019-05-20  1:26     ` Allison Randal
2019-05-20  1:11   ` Steve Winslow
2019-05-21  1:34   ` Kate Stewart
2019-05-21  5:46     ` Thomas Gleixner
2019-05-19 13:51 ` [patch 23/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 23 Thomas Gleixner
2019-05-19 17:45   ` J Lovejoy
2019-05-20  1:27     ` Allison Randal
2019-05-20  1:12   ` Steve Winslow
2019-05-21  1:35   ` Kate Stewart
2019-05-19 13:51 ` [patch 24/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 24 Thomas Gleixner
2019-05-19 17:51   ` J Lovejoy
2019-05-20  1:29     ` Allison Randal
2019-05-20  1:15   ` Steve Winslow
2019-05-21  1:36   ` Kate Stewart
2019-05-19 13:51 ` [patch 25/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 25 Thomas Gleixner
2019-05-19 17:52   ` J Lovejoy
2019-05-20  1:31     ` Allison Randal
2019-05-20  1:15   ` Steve Winslow
2019-05-21  1:37   ` Kate Stewart
2019-05-21 10:20 ` [patch 00/25] First batch Greg KH
2019-05-21 10:24   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=745cf776-8af8-e09f-7457-cbcb523fbe03@lohutok.net \
    --to=allison@lohutok.net \
    --cc=linux-spdx@vger.kernel.org \
    --cc=opensource@jilayne.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPDX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spdx/0 linux-spdx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spdx linux-spdx/ https://lore.kernel.org/linux-spdx \
		linux-spdx@vger.kernel.org
	public-inbox-index linux-spdx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spdx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git