From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB1BC04AAC for ; Mon, 20 May 2019 21:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56F30216B7 for ; Mon, 20 May 2019 21:14:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="bEqbIXiw"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=lohutok.net header.i=@lohutok.net header.b="Sn+dseax" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbfETVOu (ORCPT ); Mon, 20 May 2019 17:14:50 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:52107 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbfETVOt (ORCPT ); Mon, 20 May 2019 17:14:49 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 98D6014EE5C; Mon, 20 May 2019 17:14:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=subject:to:cc :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=sasl; bh=B7z+K3fkZGKc njsELVlZOqvuzyA=; b=bEqbIXiwNGpcQji8btu8Qa+92meRyFLOktqaKhizoiRq gT2oPzWhx490BU30/Ga0ucqaVZOtkHOhfg9WxDVmFOQjfWpXGkoFCDR6nFcKue2g ER2inSH1izuJgC70hQX41dBpAt0Bek2TiDGsRRcQXPqf5YUoEvWVO9AYeQim0UE= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 9094814EE5B; Mon, 20 May 2019 17:14:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lohutok.net; h=subject:to:cc:references:from:message-id:date:mime-version:in-reply-to:content-type:content-transfer-encoding; s=2018-11.pbsmtp; bh=ZF+ePhMUTVGd5eQWkulxY3NCHAC2we3tNLv9VbK3rqM=; b=Sn+dseaxybVRxg6EF0vTfJbpbofhvgD7DZvGlH8JDJmsA0YgohYAAhcxK76+u+7bLxYMGJGBDkUU/HCXAxElAC6rVmh2dK1b0v64o3B8Vn0eUyEchDoAr78g6Afja5QY2dT3Z3RZYT7OT1qGIQM6wC2LbMW8bUuiWLHCM+cINeA= Received: from [10.252.82.1] (unknown [198.134.98.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 6213414EE5A; Mon, 20 May 2019 17:14:46 -0400 (EDT) Subject: Re: [patch 02/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 2 To: Thomas Gleixner , J Lovejoy Cc: linux-spdx@vger.kernel.org References: <20190519135130.462579320@linutronix.de> <20190519154040.743319710@linutronix.de> From: Allison Randal Message-ID: <745cf776-8af8-e09f-7457-cbcb523fbe03@lohutok.net> Date: Mon, 20 May 2019 14:14:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 4BC29804-7B44-11E9-9F0C-E828E74BB12D-44123303!pb-smtp2.pobox.com Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On 5/20/19 6:47 PM, Thomas Gleixner wrote: > > We really need to spot the failures in the patterns, not the actual file > level patches. The patcher itself is going to remove the file level > equivalent of the normalized pattern and add the concluded SPDX identifier > instead. Not more, not less. I'll back that up: the word *library* was in the pattern, and that's the only reason it matched that file. So, in our reviews, we need to carefully check that the pattern correctly corresponds to the SPDX identifier. But, the pattern matches are very literal/exact, so we don't need to be worried about some random files that don't exactly match the pattern sneaking into the patch, or review every file in the patch. (I do review a few files, but it's just for the mental reassurance that I've read the pattern correctly.) > If the tools would be perfect we would not need to look at any of these > things ... Fuzzy text matching is hard. This is why we have SPDX. :) Our efforts here will make a million future license compliance scans of the Kernel cleaner and more accurate. Allison