linux-spdx.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Nishanth Menon <nm@ti.com>,
	Thorsten Leemhuis <linux@leemhuis.info>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-spdx@vger.kernel.org,
	Nishanth Menon <nm@ti.com>, Christoph Hellwig <hch@lst.de>,
	Rahul T R <r-ravikumar@ti.com>
Subject: Re: [PATCH] LICENSES/dual/CC-BY-4.0: Lets switch to utf-8
Date: Mon, 05 Jul 2021 09:08:11 -0600	[thread overview]
Message-ID: <875yxokdd0.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210703012931.30604-1-nm@ti.com>

Nishanth Menon <nm@ti.com> writes:

> Lets drop the unicode characters that peeped in and replace with
> equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with
> rest of license files.
>
> This messes up code such as scripts/spdxcheck.py which assumed utf-8
> LICENSE files.
>
> Fixes: bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")

So...this file *is* in UTF-8; I'm finding your changelog a bit
confusing. 

> Cc: Thorsten Leemhuis <linux@leemhuis.info>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Christoph Hellwig <hch@lst.de>
> Cc: Jonathan Corbet <corbet@lwn.net>
>
> Reported-by: Rahul T R <r-ravikumar@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> also see: https://lore.kernel.org/linux-spdx/20210703012128.27946-1-nm@ti.com/T/#u
>
>  LICENSES/dual/CC-BY-4.0 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/LICENSES/dual/CC-BY-4.0 b/LICENSES/dual/CC-BY-4.0
> index 45a81b8e4669..869cad3d1643 100644
> --- a/LICENSES/dual/CC-BY-4.0
> +++ b/LICENSES/dual/CC-BY-4.0
> @@ -392,7 +392,7 @@ Section 8 -- Interpretation.
>  Creative Commons is not a party to its public
>  licenses. Notwithstanding, Creative Commons may elect to apply one of
>  its public licenses to material it publishes and in those instances
> -will be considered the “Licensor.” The text of the Creative Commons
> +will be considered the "Licensor." The text of the Creative Commons

It seems that what you're really doing is replacing "smart quotes" with
the basic ASCII variety?  That seems like a fine thing to do, but that's
not really what the changelog says.

I can tweak it when I apply this.

Meanwhile, though, if there's a bug it's the spdxcheck.py issue reported
by Rahul.  That problem doesn't reproduce here; he must be running in an
environment where ASCII is assumed.  Being explicit about the encoding
expected is the right fix in any case...  Maybe I'll snag that patch as
well if nobody else beats me to it.

Thanks,

jon

  parent reply	other threads:[~2021-07-05 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-03  1:29 Nishanth Menon
2021-07-03  1:34 ` Randy Dunlap
2021-07-05 15:08 ` Jonathan Corbet [this message]
2021-07-06  6:59   ` Thorsten Leemhuis
2021-07-06 12:48   ` Nishanth Menon
2021-07-07  9:04 ` Thomas Gleixner
2021-07-07 16:41   ` Pavel Machek
2021-07-12 16:03 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yxokdd0.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spdx@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=nm@ti.com \
    --cc=r-ravikumar@ti.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] LICENSES/dual/CC-BY-4.0: Lets switch to utf-8' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).