Linux-SPDX Archive on lore.kernel.org
 help / color / Atom feed
From: Richard Fontana <rfontana@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-spdx@vger.kernel.org
Subject: Re: [Batch 5 - patch 08/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 108
Date: Thu, 23 May 2019 07:54:41 -0400
Message-ID: <CAC1cPGxE2hafbu_5ZrUS5ATpU7s4OREt=JfSESM12F4r3kS7aw@mail.gmail.com> (raw)
In-Reply-To: <20190523091650.100885018@linutronix.de>

On Thu, May 23, 2019 at 5:29 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Based on 1 normalized pattern(s):
>
>   gnupg is free software you can redistribute it and or modify it
>   under the terms of the gnu general public license as published by
>   the free software foundation either version 2 of the license or at
>   your option any later version gnupg is distributed in the hope that
>   it will be useful but without any warranty without even the implied
>   warranty of merchantability or fitness for a particular purpose see
>   the gnu general public license for more details you should have
>   received a copy of the gnu general public license along with this
>   program if not write to the free software foundation inc 59 temple
>   place suite 330 boston ma 02111 1307 usa

At least some of these bear FSF copyrights. I noticed some other
patches that made reference to "GNU CC" (suggesting the code may have
been taken from old versions of GCC?) but I am not sure they had FSF
copyrights.

I feel it is especially awkward to remove the continuously-preferred
legal notice of the copyright holder, particularly when that copyright
holder is also the recognized license steward of the license in
question. Since John Sullivan is on this list maybe he can comment.
Obviously if the FSF is okay with it, it's fine, but I am not sure
that is John's view given a comment he made the other day.

As a generalization of the above concern, it seems relatively
problematic to me to replace license notices that were attached to
code taken from non-Linux projects, where that is evident, compared to
code contributed to Linux in the first instance. (Similarly, I would
normally not advise Red Hat employees to alter upstream third-party
legal notices downstream, except in very unusual circumstances.)

Richard



>
> extracted by the scancode license scanner the SPDX license identifier
>
>   GPL-2.0-or-later
>
> has been chosen to replace the boilerplate/reference in 4 file(s).
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-spdx.git/commit/?h=batch5&id=cad8bc93c21d
> ---
>  lib/mpi/mpi-bit.c  |   15 +--------------
>  lib/mpi/mpi-cmp.c  |   15 +--------------
>  lib/mpi/mpicoder.c |   15 +--------------
>  lib/mpi/mpiutil.c  |   15 +--------------
>  4 files changed, 4 insertions(+), 56 deletions(-)
>
> --- a/lib/mpi/mpi-bit.c
> +++ b/lib/mpi/mpi-bit.c
> @@ -1,21 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /* mpi-bit.c  -  MPI bit level fucntions
>   * Copyright (C) 1998, 1999 Free Software Foundation, Inc.
>   *
>   * This file is part of GnuPG.
> - *
> - * GnuPG is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * GnuPG is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
>   */
>
>  #include "mpi-internal.h"
> --- a/lib/mpi/mpi-cmp.c
> +++ b/lib/mpi/mpi-cmp.c
> @@ -1,21 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /* mpi-cmp.c  -  MPI functions
>   * Copyright (C) 1998, 1999 Free Software Foundation, Inc.
>   *
>   * This file is part of GnuPG.
> - *
> - * GnuPG is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * GnuPG is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
>   */
>
>  #include "mpi-internal.h"
> --- a/lib/mpi/mpicoder.c
> +++ b/lib/mpi/mpicoder.c
> @@ -1,21 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /* mpicoder.c  -  Coder for the external representation of MPIs
>   * Copyright (C) 1998, 1999 Free Software Foundation, Inc.
>   *
>   * This file is part of GnuPG.
> - *
> - * GnuPG is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * GnuPG is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
>   */
>
>  #include <linux/bitops.h>
> --- a/lib/mpi/mpiutil.c
> +++ b/lib/mpi/mpiutil.c
> @@ -1,21 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /* mpiutil.ac  -  Utility functions for MPI
>   * Copyright (C) 1998, 1999 Free Software Foundation, Inc.
>   *
>   * This file is part of GnuPG.
> - *
> - * GnuPG is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * GnuPG is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
>   */
>
>  #include "mpi-internal.h"
>
>


-- 
Richard Fontana
Senior Commercial Counsel
Red Hat, Inc.

  reply index

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  9:14 [Batch 5 - patch 00/25] Batch 5 of random GPL notices/references Thomas Gleixner
2019-05-23  9:14 ` [Batch 5 - patch 01/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 101 Thomas Gleixner
2019-05-23 12:44   ` Richard Fontana
2019-05-23 22:18   ` Allison Randal
2019-05-24  1:10   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 02/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 102 Thomas Gleixner
2019-05-23 12:08   ` Richard Fontana
2019-05-23 22:18   ` Allison Randal
2019-05-24  1:10   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 03/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 103 Thomas Gleixner
2019-05-23 12:52   ` Richard Fontana
2019-05-23 22:19   ` Allison Randal
2019-05-24  1:11   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 04/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 104 Thomas Gleixner
2019-05-23 12:41   ` Richard Fontana
2019-05-23 22:20   ` Allison Randal
2019-05-24  1:12   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 05/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 105 Thomas Gleixner
2019-05-23 11:44   ` Richard Fontana
2019-05-23 22:21   ` Allison Randal
2019-05-24  1:12   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 06/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 106 Thomas Gleixner
2019-05-23 11:45   ` Richard Fontana
2019-05-23 22:21   ` Allison Randal
2019-05-24  1:13   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 07/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 107 Thomas Gleixner
2019-05-23  9:45   ` Thomas Gleixner
2019-05-23  9:14 ` [Batch 5 - patch 08/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 108 Thomas Gleixner
2019-05-23 11:54   ` Richard Fontana [this message]
2019-05-23 12:36     ` Thomas Gleixner
2019-05-23 13:06       ` Thomas Gleixner
2019-05-23  9:14 ` [Batch 5 - patch 09/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 109 Thomas Gleixner
2019-05-23  9:46   ` Thomas Gleixner
2019-05-23  9:14 ` [Batch 5 - patch 10/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 110 Thomas Gleixner
2019-05-23 12:43   ` Richard Fontana
2019-05-23 22:26   ` Allison Randal
2019-05-24  1:13   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 11/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 111 Thomas Gleixner
2019-05-23 12:43   ` Richard Fontana
2019-05-23 22:26   ` Allison Randal
2019-05-24  1:14   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 12/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 112 Thomas Gleixner
2019-05-23 12:43   ` Richard Fontana
2019-05-23 22:27   ` Allison Randal
2019-05-24  1:14   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 13/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 113 Thomas Gleixner
2019-05-23 12:07   ` Richard Fontana
2019-05-23 22:27   ` Allison Randal
2019-05-24  1:15   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 14/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 114 Thomas Gleixner
2019-05-23 12:38   ` Richard Fontana
2019-05-23 22:28   ` Allison Randal
2019-05-24 10:51   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 15/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 115 Thomas Gleixner
2019-05-23 12:42   ` Richard Fontana
2019-05-23  9:14 ` [Batch 5 - patch 16/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 116 Thomas Gleixner
2019-05-23 12:39   ` Richard Fontana
2019-05-23 22:30   ` Allison Randal
2019-05-23  9:14 ` [Batch 5 - patch 17/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 117 Thomas Gleixner
2019-05-23  9:51   ` Thomas Gleixner
2019-05-23 12:02   ` Richard Fontana
2019-05-23 12:24     ` Thomas Gleixner
2019-05-23  9:14 ` [Batch 5 - patch 18/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 118 Thomas Gleixner
2019-05-23 12:06   ` Richard Fontana
2019-05-23 22:32   ` Allison Randal
2019-05-24 10:55   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 19/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 119 Thomas Gleixner
2019-05-23 12:38   ` Richard Fontana
2019-05-23 22:33   ` Allison Randal
2019-05-24 10:56   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 20/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 120 Thomas Gleixner
2019-05-23 12:37   ` Richard Fontana
2019-05-23 22:33   ` Allison Randal
2019-05-24 10:57   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 21/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 121 Thomas Gleixner
2019-05-23 12:10   ` Richard Fontana
2019-05-23 22:34   ` Allison Randal
2019-05-24 10:58   ` Kate Stewart
2019-05-23  9:14 ` [Batch 5 - patch 22/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 122 Thomas Gleixner
2019-05-23 12:09   ` Richard Fontana
2019-05-23 22:35   ` Allison Randal
2019-05-24 10:59   ` Kate Stewart
2019-05-23  9:15 ` [Batch 5 - patch 23/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 123 Thomas Gleixner
2019-05-23 12:08   ` Richard Fontana
2019-05-23 22:36   ` Allison Randal
2019-05-24 11:00   ` Kate Stewart
2019-05-23  9:15 ` [Batch 5 - patch 24/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 124 Thomas Gleixner
2019-05-23  9:52   ` Thomas Gleixner
2019-05-23 22:42     ` Allison Randal
2019-05-24  5:50       ` Thomas Gleixner
2019-05-24 12:00         ` Kate Stewart
2019-05-24 12:33           ` Thomas Gleixner
2019-05-24 15:09             ` Allison Randal
2019-05-24 16:16               ` Thomas Gleixner
2019-05-24 17:15                 ` Allison Randal
2019-06-02 18:06             ` J Lovejoy
2019-05-23 12:51   ` Richard Fontana
2019-05-23  9:15 ` [Batch 5 - patch 25/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 125 Thomas Gleixner
2019-05-23 12:10   ` Richard Fontana
2019-05-23 22:41   ` Allison Randal
2019-05-24 11:00   ` Kate Stewart

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC1cPGxE2hafbu_5ZrUS5ATpU7s4OREt=JfSESM12F4r3kS7aw@mail.gmail.com' \
    --to=rfontana@redhat.com \
    --cc=linux-spdx@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-SPDX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-spdx/0 linux-spdx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-spdx linux-spdx/ https://lore.kernel.org/linux-spdx \
		linux-spdx@vger.kernel.org
	public-inbox-index linux-spdx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-spdx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git