From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63102C282DC for ; Sun, 2 Jun 2019 23:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E6B5277BE for ; Sun, 2 Jun 2019 23:58:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=turingmachine-org.20150623.gappssmtp.com header.i=@turingmachine-org.20150623.gappssmtp.com header.b="QXwNREcn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726305AbfFBX6R (ORCPT ); Sun, 2 Jun 2019 19:58:17 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:40445 "EHLO mail-lf1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbfFBX6R (ORCPT ); Sun, 2 Jun 2019 19:58:17 -0400 Received: by mail-lf1-f49.google.com with SMTP id a9so10700925lff.7 for ; Sun, 02 Jun 2019 16:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=turingmachine-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6Efrxbe3djgAn+XqKiYxjqabxn6UR8ILitvVp0YY4Rg=; b=QXwNREcnF8BG1Z19O3D9G5Ts1aKsNJn0XmR8iDyR2YA8vHufJh0+kQ34+926DyM39I aC+q8xVmy9KnqDb0/3X/GUnZTobPN8f1XXCwkQdfB1eGE+AYMhJosNtQbdF/JT5T64ct 9sgrRsiGhXy+n6kCxBw+kEPA/G7C2U4sHRxiVCaSPNW5NAhfLie53gB168j0C4+WbO27 sZcmhMBEhTAPtw7O0JnC+uxpOTfWhXOyZr2kjxk0lTJts14DAMWA09iQMaM2pwPFlnRA Un8tU2qa1mnJ919Q51q/q+jxLdg87ECmjrbvAi9hVRCvgAx8op5Kgz9WWZVk+kKweSI6 OSsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6Efrxbe3djgAn+XqKiYxjqabxn6UR8ILitvVp0YY4Rg=; b=WBkEhMnfoP9NvyI7sjHsn2lBiE5M7fjAYpkBkFRVEa4ytDhQ8JE3a+U1D3oLfLPs32 xdY3sLRlQ2RiADoPEn3zLJ/vz9zbQ1LArijmpILGf7+LF0ljBj5wyLbxB7ZiSBbTcpDl Tpd1QrMz+0YnfMJhJem84pCK7x6DtiCNoDi7OejK+lSiExJmaqxAhhFBOdzpqkB4Tk1/ EvuSyHK9lAgkIxfVzfxTAkGYXdCWrTkqQ7On+NHZH+lVQJKX/7gkGX+Pf+/4n4QCuy7A 4ssE9Q7hsWBPqZZtDpo3fEJn8huoupSDt+j+iL5ash/ITyvUuRlhk8dBRnQIwSl2adBh O3CQ== X-Gm-Message-State: APjAAAV5lmnvtyVqhYbUtqvnciJGdbaB47L28X3b90bqo0dz6s7zTDz6 DSOtktzH/npjlc3rDxLfibuADfCAyc7ZHKN2laQ= X-Google-Smtp-Source: APXvYqxewLisa4cJbqIbBLrVS53lNK7AWCTi/YXWTWYJYLAG8a/NETjpsnnAq3fosKAKHyA25NrTLdbUMlpRSaZbYK8= X-Received: by 2002:ac2:4156:: with SMTP id c22mr11856570lfi.12.1559519895473; Sun, 02 Jun 2019 16:58:15 -0700 (PDT) MIME-Version: 1.0 References: <20190531185815.510185089@linutronix.de> <20190531190115.503150771@linutronix.de> In-Reply-To: <20190531190115.503150771@linutronix.de> From: dmg Date: Sun, 2 Jun 2019 16:57:38 -0700 Message-ID: Subject: Re: [Batch 15 patch 40/49] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441 To: Thomas Gleixner , linux-spdx@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org Hi Thomas, I did a comprehensive review of this patch (it is huge), using a context of 40 lines instead of the default of 3, looking for files that might have had another licensing information attached to them. I did not find any error. - I found several cases in which the file was based upon another file (according to the comments, e.g drivers/gpio/gpio-max732x.c). The few cases I followed were consistent (the original file was also GPL-2.0-only). I assume the license of the original file does not matter. - A minor issue, some SPDX headers in C files are commented with /* */ (eg sound/soc/nuc900/nuc900-audio.h) and some with // (eg arch/arm/mach-w90x900/clksel.c). Does that matter?