Re: [PATCH] scripts: switch some more scripts explicitly to Python 3

From: Masahiro Yamada <masahiroy@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	clang-built-linux <clang-built-linux@googlegroups.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-spdx@vger.kernel.org
Subject: Re: [PATCH] scripts: switch some more scripts explicitly to Python 3
Date: Tue, 2 Feb 2021 15:09:38 +0900	[thread overview]
Message-ID: <CAK7LNATSna9f8cd5Lm=zx2vfJzk=WUnAUkA8V593O304zTx=vQ@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdnECGDFe=n6ms0Aj7FB0sN7ktZyk4dyVvV0UTgPvpuWpA@mail.gmail.com>

On Tue, Feb 2, 2021 at 3:28 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Sun, Jan 31, 2021 at 5:08 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > For the same reason as commit 51839e29cb59 ("scripts: switch explicitly
> > to Python 3"), switch some more scripts, which I tested and confirmed
> > working on Python 3.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Thanks for the patch. It's time to move on from Python 2.
>
> It looks like there's already a patch in -next for scripts/spdxcheck.py.
> ("spdxcheck.py: Use Python 3") by Bert Vermeulen.
> https://lore.kernel.org/r/20210121085412.265400-1-bert@biot.com

OK, I dropped the spdxcheck.py change in v2.

> What about:
> scripts/tracing/draw_functrace.py
> scripts/show_delta
> scripts/jobserver-exec
>
> Or do those need additional source level changes?

I touched jobserver-exec in this patch:

https://patchwork.kernel.org/project/linux-kbuild/patch/20210201010024.654526-1-masahiroy@kernel.org/

I have not tested draw_functrac.py or show_delta.

> > ---
> >
> >  scripts/clang-tools/gen_compile_commands.py | 2 +-
> >  scripts/clang-tools/run-clang-tools.py      | 2 +-
> >  scripts/spdxcheck.py                        | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
> > index 19963708bcf8..8ddb5d099029 100755
> > --- a/scripts/clang-tools/gen_compile_commands.py
> > +++ b/scripts/clang-tools/gen_compile_commands.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/env python3
> >  # SPDX-License-Identifier: GPL-2.0
> >  #
> >  # Copyright (C) Google LLC, 2018
> > diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
> > index fa7655c7cec0..f754415af398 100755
> > --- a/scripts/clang-tools/run-clang-tools.py
> > +++ b/scripts/clang-tools/run-clang-tools.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/env python3
> >  # SPDX-License-Identifier: GPL-2.0
> >  #
> >  # Copyright (C) Google LLC, 2020
> > diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
> > index bc87200f9c7c..cbdb5c83c08f 100755
> > --- a/scripts/spdxcheck.py
> > +++ b/scripts/spdxcheck.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python
> > +#!/usr/bin/env python3
> >  # SPDX-License-Identifier: GPL-2.0
> >  # Copyright Thomas Gleixner <tglx@linutronix.de>
> >
> > --
> > 2.27.0
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers

-- 
Best Regards
Masahiro Yamada